GNOME Bugzilla – Bug 627761
gtksourceview-3.0 bindings
Last modified: 2011-07-27 04:30:29 UTC
Created attachment 168585 [details] [review] gtksourceview-3.0 bindings Attached a patch for gtksourceview-3.0 bindings.
I'd love to see these committed to trunk. They are a prerequisite for gedit 3 bindings (bug 645624).
Actually it seems that the bindings in Jesse's patch are now out of date (unsuprisingly, since they were posted over 7 months ago). When I try to build with them I get errors (see below). So I think they need to be updated before we can commit them. gtksourceview-3.0.vapi:55.34-55.43: error: The type name `Gtk.Object' could not be found public class SourceCompletion : Gtk.Object { ^^^^^^^^^^ gtksourceview-3.0.vapi:108.82-108.96: error: The type name `Gtk.SizeRequest' could not be found ...
In this page [1] there is a gtksourceview-3.0.vapi from Vala Toys for Gedit. [1] https://live.gnome.org/Vala/BindingsStatus
I have modified a bit the one from Vala Toys, it is available here: https://github.com/swilmet/latexila/raw/gnome-3/vapi/gtksourceview-3.0.vapi See bug #628704 and bug #648622.
Created attachment 192148 [details] [review] Add gtksourceview-3.0 bindings. I don't think we want to accept any more GIDL-based bindings. I've attached some GIR-based ones I just generated… can you take a look at them and let me know if they work okay? If so, I'll go ahead and push them.
Evan, I've tested your new vapi, and there are some differences with gtksourceview-2.0.vapi: CompletionProvider.get_icon () can return null, so the return type should have a "?". Idem for CompletionProvider.get_info_widget (). All the methods of CompletionProvider and some of CompletionProposal should be virtual, not abstract (see bug #628704).
Created attachment 192632 [details] [review] Add gtksourceview-3.0 bindings Updated patch. Should just need to change the namespace to Gtk instead of GtkSource for compatibility with gtksourceview-2.0.vapi
commit 29a0353c3747567b764ae3151124f092d5fc3c87 Author: Evan Nemerson <evan@coeus-group.com> Date: Tue Jul 26 21:23:26 2011 -0700 Add gtksourceview-3.0 bindings Fixes bug 627761.