After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628704 - Gtk.SourceCompletionProposal and Provider: abstract classes instead of interfaces
Gtk.SourceCompletionProposal and Provider: abstract classes instead of interf...
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-03 14:04 UTC by Sébastien Wilmet
Modified: 2010-10-23 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtksourceview-2.0: Make some interface methods virtual, not abstract. (5.81 KB, patch)
2010-10-02 20:08 UTC, Evan Nemerson 		none Details | Review

Description Sébastien Wilmet 2010-09-03 14:04:06 UTC 
Gtk.SourceCompletionProposal and Gtk.SourceCompletionProvider are interfaces in gtksourceview-2.0.vapi.

But normally we don't have to implement all methods. An example is given in tests/test-completion.py of gtksourceview source code, and we see that the subclass of CompletionProvider doesn't implement all methods.

So I think it should be abstract classes instead of interfaces.
Comment 1 Evan Nemerson 2010-10-02 20:08:46 UTC 
Created attachment 171588 [details] [review]
gtksourceview-2.0: Make some interface methods virtual, not abstract.

Unless I'm misunderstanding something, the problem isn't that they are interfaces instead of abstract classes. Rather, the problem is that the methods are abstract instead of virtual. Give this patch a try, if it fixes your issue I'll go ahead and push it.
Comment 2 Evan Nemerson 2010-10-23 08:17:17 UTC 
commit 99539587fd28719f2d5d3ab75f53f73309284ad4
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Sat Oct 2 13:02:08 2010 -0700

    gtksourceview-2.0: Make some interface methods virtual, not abstract
    
    Fixes bug 628704.
Comment 3 Sébastien Wilmet 2010-10-23 12:44:26 UTC 
Sorry for my late response, the patch fixes the problem, thank you!