After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627368 - [notification_area] Fix some bugs from the GSEALing
[notification_area] Fix some bugs from the GSEALing
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: notification area
unspecified
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-19 14:13 UTC by Dan Winship
Modified: 2010-08-23 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[notification_area] Fix some bugs from the GSEALing (2.65 KB, patch)
2010-08-19 14:13 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2010-08-19 14:13:12 UTC 
there may be similar problems elsewhere; we were only looking at the
na-tray code
Comment 1 Dan Winship 2010-08-19 14:13:19 UTC 
Created attachment 168290 [details] [review]
[notification_area] Fix some bugs from the GSEALing

na-tray-child.c had C99 mixed code and declarations.
na-tray-manager.c was calling methods on an object before checking that
it was non-NULL

Noticed while syncing the code to gnome-shell, bug 627306
Comment 2 Vincent Untz 2010-08-23 13:52:22 UTC 
Review of attachment 168290 [details] [review]:

Thanks, please commit.
Comment 3 Dan Winship 2010-08-23 17:10:07 UTC 
Attachment 168290 [details] pushed as e08b975 - [notification_area] Fix some bugs from the GSEALing