Created attachment 168235 [details] [review]
[tray] sync NaTray code from gnome-panel

Our copies and gnome-panel's had been ported for GSEAL independently.
Sync them back up again.

Created attachment 168236 [details] [review]
[ShellTrayManager] a few updates

Use the new na_tray_child_get_wm_class() method.
Add the trayicon title to the signal.

Review of attachment 168235 [details] [review]:

Couple of small things that need to be fixed (and presumably pushed back to gnome-panel). Otherwise, OK to commit.

::: src/tray/na-tray-child.c
@@ +140,3 @@
+                   allocation->y != widget_allocation.y;
+  gboolean resized = allocation->width != widget_allocation.width ||
+                     allocation->height != widget_allocation.height;

mixed-declarations-and-code

::: src/tray/na-tray-manager.c
@@ +591,1 @@
+  if (!manager->invisible || !window)

manager->invisible is used before it is checked for NULL

@@ +623,1 @@
+  if (!manager->invisible || !window)

And again here

Review of attachment 168236 [details] [review]:

Sort of confusing that the JS prototype connected to the signal wasn't modified to have the extra parameter, but will work fine sending in an extra parameter and patch looks OK.

(In reply to comment #4)
> Sort of confusing that the JS prototype connected to the signal wasn't modified
> to have the extra parameter, but will work fine sending in an extra parameter
> and patch looks OK.

yeah, it will get used by the new tray manager in 608869, i just rearranged the patches and this seemed to make more sense here

filed bug 627368 against gnome-panel

Attachment 168235 [details] pushed as 7ff7ec0 - [tray] sync NaTray code from gnome-panel
Attachment 168236 [details] pushed as d9169d2 - [ShellTrayManager] a few updates