GNOME Bugzilla – Bug 627258
Find dialog cosmetics
Last modified: 2015-09-27 19:28:17 UTC
Love the new search feature! Dunno if you agree, but I played with the .ui file to make the dialog a bit more HIGgy (12px) and compact. I guess other locales may have longer strings and all, but at least it would only expand if needed. BTW, the search behaves oddly when there’s only one match. Upon »Search Next« it just unhighlights the one match. I think it should keep the highlight.
Created attachment 168198 [details] Before/After Screenshot
Created attachment 168199 [details] [review] my dilettantic patch for find-dialog.ui
Looks better, yes. However making the last checkbox span both columns doesn't seem right, given that this decision is based on the length of the *english* strings, while the string lengths may be completely different in other languages. Also unfortunately we're in UI freeze, so this needs to be postponed to 2.33.
Actually I decided that UI freeze didn't apply to at least HIGifying the spacings etc, so I made some adjustments.
- "Match as word" doesn't make sense to me. - I made the dialog match gedit. I think being consistent is important. - A wide dialog is not such a bad thing, given that you can type regex too. - Maybe these don't really matter since we'll eventually move to a search bar. - Currently search is very, very naive and broken. However, if there's only one result, I do like hitting a "not-found" result if you repeat the search instead of doing nothing silently.
(In reply to comment #5) > - "Match as word" doesn't make sense to me. I know. I wanted two columns. Proof of concept only. > - I made the dialog match gedit. I think being consistent is important. I looked at it as well. Not 100% HIG and too big. It pops up in the center and obscures the text. Not the best model. > - A wide dialog is not such a bad thing, given that you can type regex too. Maybe, I like to use regex too, but beautiful apps like gnome-terminal deserve beautiful dialogs. Gedit’s looks sloppy. > - Maybe these don't really matter since we'll eventually move to a search bar. Much better model, but how to fit four toggles? > - Currently search is very, very naive and broken. However, if there's only > one result, I do like hitting a "not-found" result if you repeat the search > instead of doing nothing silently. Ok. But that’s inconsistent with all other apps. Try it.
(In reply to comment #5) > - Currently search is very, very naive and broken. If it's broken, shouldn't we disable this for stable 2.32 ?
(In reply to comment #7) > (In reply to comment #5) > > - Currently search is very, very naive and broken. > > If it's broken, shouldn't we disable this for stable 2.32 ? Well, not broken in that sense. It works. It's useful. It just can be improved in a thousand ways before I can say I'm very happy with it. Filed those as bug 627886.
Replacing the find dialogue with a find popup like gedit: http://git.gnome.org/browse/gnome-terminal/commit/?h=wip/newsearch&id=c123ede0c9dbbf72a6814e03d55ecb1cb47ee4ec
Screenshot please!
Created attachment 209645 [details] find popup
+1 (but what about the options? I’m in barely contained anticipation of the day where we’ll have highlighting of all matches. in combination with regex this will be super-f’ing-nifty)
Just occured to me that hits in the scrollback when searching backwards are highlighted on the bottom line. Wouldn’t it make sense to give it a bit of scrolloff (vim terminology) or something similar to less -j.5?
this looks very nice ! any thoughts on merging it ?
Find has been redesigned as a popover in master (one remaining issue is being tracken in bug 755653).