After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755653 - Search popover might cover search result
Search popover might cover search result
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Reported: 2015-09-26 01:59 UTC by Egmont Koblinger
Modified: 2021-06-10 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

terminix search (68.34 KB, image/png)
2016-02-20 17:48 UTC, alex diavatis

Description Egmont Koblinger 2015-09-26 01:59:55 UTC
The viewport should be scrolled so that the search result is not underneath the new search popover.
Comment 1 Christian Persch 2015-09-26 17:25:24 UTC
Or alternatively the popover could switch to the bottom if the result is in the top half of the screen, and back to the top if the result is in the bottom half of the screen.
Comment 2 Egmont Koblinger 2015-09-27 16:05:10 UTC
Yup. Harder to use if you click with the mouse (it's irritating if the button keeps going away from the mouse), but would still work if the search result is at the very beginning of the scrollback. (Or maybe a combination of both approaches.)

For either approach I'm afraid we need to extend the API.
Comment 3 Christian Persch 2015-09-27 16:24:42 UTC
How about a vte_terminal_search_find_full() that unifies next/prev with a bool argument, and has a a GdkRectangle out param to return the on-screen coords of the match?
Comment 4 Egmont Koblinger 2015-09-27 18:59:58 UTC
How about making this GdkRectangle an in-out param: It would tell vte to preferably place the search result in that area, and in turn vte would tell us where it actually placed it.

The "in" direction would allow the search popover not to crazily jump up-n-down as you just iterate over all matches; only jump if absolutely necessary.
Comment 5 Matthias Clasen 2015-09-28 12:22:49 UTC
Please, no jumping popovers.
Comment 6 Christian Persch 2016-02-16 18:01:43 UTC
I've reverted to using a window instead of the popover, for 3.20.
Comment 7 alex diavatis 2016-02-20 17:48:27 UTC
Created attachment 321731 [details]
terminix search

This is how Terminix does it, with the standard search revealer in Gnome. 
I'm adding it as an idea.
Comment 8 GNOME Infrastructure Team 2021-06-10 21:00:10 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: