GNOME Bugzilla – Bug 755653
Search popover might cover search result
Last modified: 2021-06-10 21:00:10 UTC
The viewport should be scrolled so that the search result is not underneath the new search popover.
Or alternatively the popover could switch to the bottom if the result is in the top half of the screen, and back to the top if the result is in the bottom half of the screen.
Yup. Harder to use if you click with the mouse (it's irritating if the button keeps going away from the mouse), but would still work if the search result is at the very beginning of the scrollback. (Or maybe a combination of both approaches.)
For either approach I'm afraid we need to extend the API.
How about a vte_terminal_search_find_full() that unifies next/prev with a bool argument, and has a a GdkRectangle out param to return the on-screen coords of the match?
How about making this GdkRectangle an in-out param: It would tell vte to preferably place the search result in that area, and in turn vte would tell us where it actually placed it.
The "in" direction would allow the search popover not to crazily jump up-n-down as you just iterate over all matches; only jump if absolutely necessary.
Please, no jumping popovers.
I've reverted to using a window instead of the popover, for 3.20.
Created attachment 321731 [details]
This is how Terminix does it, with the standard search revealer in Gnome.
I'm adding it as an idea.
-- GitLab Migration Automatic Message --
This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/7595.