GNOME Bugzilla – Bug 627033
Refactor vapigen to validate .metadata contents
Last modified: 2010-11-08 10:37:33 UTC
This patch refactors the .metadata file handling within vapigen to: * Enumerate explicitly all metadata attribute keywords inside the vala code * Centralise parsing/split to double/int/comma delimited etc into one place * Allow output of a symbols file containing a list of valid attribute keys for each symbol discovered during execution The patch has been regression tested using: https://bugzilla.gnome.org/show_bug.cgi?id=624155 The results below reflect equivalent output as non-patched HEAD regression testing, with the added bonus that with the patch the errors listed below become visible. Report: Total candidate vapis: 75 Libraries not installed on current machine: 19 Generated VAPI matches existing version: 52 Generated VAPI differs from existing version: 4 gdu gdu-gtk gtk+-2.0 libgda-4.0 Errors encountered during generation: 4 gdk-pixbuf-2.0 gedit-2.20 gstreamer-0.10 gtk+-2.0 I will create new bugs for fixes to the .metadata files that this patch has found.
Created attachment 167952 [details] [review] Vapigen metadata validation patch v1
For reference, this patch includes the GLib.Critical patch found at: https://bugzilla.gnome.org/show_bug.cgi?id=622561
Created attachment 167963 [details] [review] V2 of metadata validating vapigen patch including correct copyright header
Created attachment 168270 [details] [review] V3 metadata validating vapigen patch * Includes fix to use "hidden" on interfaces. Bugzilla bug with fix to standard vapigen tree: https://bugzilla.gnome.org/show_bug.cgi?id=627298
The GIR parser now warns about this, and we're moving away from GIDL, so I'm going to mark this as obsolete.