After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622561 - valagirparser bad assumption before split call
valagirparser bad assumption before split call
Status: RESOLVED OBSOLETE
Product: vala
Classification: Core
Component: Bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-24 06:31 UTC by Daniel Hams
Modified: 2010-11-24 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix GLib:Criticals on metadata lines with one token (719 bytes, patch)
2010-06-24 06:33 UTC, Daniel Hams 		none Details | Review

Description Daniel Hams 2010-06-24 06:31:58 UTC 
Problem:

A line like the following in the .metadata file causes a GLib:Critical:

'blah'

I.e. A line with a single token with no whitespace.

Cause:

line split done on space but following code doesn't check that 2 or more tokens are returned.

Fix:

Modify parse_metadata method to skip over lines that don't have a second token.

Patch attached.
Comment 1 Daniel Hams 2010-06-24 06:33:00 UTC 
Created attachment 164474 [details] [review]
Fix GLib:Criticals on metadata lines with one token
Comment 2 Daniel Hams 2010-08-16 11:17:54 UTC 
For reference, this fix has been included in the patch provided in:

https://bugzilla.gnome.org/show_bug.cgi?id=627033
Comment 3 Luca Bruno 2010-11-24 12:42:27 UTC 
Commit a72acba1ef94af6d48e437fb8a3650fe521e0c2a
From: Luca Bruno <lucabru@src.gnome.org>
Date: Sun, 29 Aug 2010 11:02:25 +0000

   girparser: Replace parse_metadata with MetadataParser

Thanks for the report and for writing the patch.
Metadata parser has completely changed. Closing the bug as obsolete.
Please feel free to open new bugs against the new metadata parser.