GNOME Bugzilla – Bug 626788
language list not pretty in GDM login
Last modified: 2010-08-13 20:07:47 UTC
For gdm when you bring up the list of languages doesn't look great, e.g.it comes like . . <span lang="en">English (United Kingdom)</span> <span lang="en">English (United States)</span> Happens in Solaris (should be there in other distros as well ?) from gdm-2.30.3 onwards.
Created attachment 167779 [details] [review] patch to do the g_markup_escape_text only without the general markup tag </span>
Seems like the issue happens with the fix for Bug 619588 - User's Real names should be escaped against XML markup (https://bugzilla.gnome.org/show_bug.cgi?id=619588) The patch for escaping names before showing in markup http://bugzilla-attachments.gnome.org/attachment.cgi?id=163361 basically does the following to the language list name, which already contains marked up text (dbx) p name name = 0x81c3750 "<span lang="zh">\xe6\xbc\xa2\xe8\xaa\x9e (\xe5\x8f\xb0\xe7\x81\xa3)</span>" (dbx) p escaped escaped = 0x81c4218 "<span lang="zh">\xe6\xbc\xa2\xe8\xaa\x9e (\xe5\x8f\xb0\xe7\x81\xa3)</span>" Here escaped = g_markup_escape_text (name, -1); We don't need the step for the language list with properly marked up text, only for usernames which contain XML markup like & or < See the attached patch which will solve this. I have hardcoded "</span>" as the markup tag to search for (from http://library.gnome.org/devel/pango/stable/PangoMarkupFormat.html), which seems to be sufficient for the job at hand.
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 624847 ***