GNOME Bugzilla – Bug 619588
User's Real names should be escaped against XML markup
Last modified: 2010-06-17 00:21:44 UTC
If one user on the system has a Real name containing XML markup like & or <, the users list behaves badly. Sometimes you get twice the same user name. This seems to be because the string isn't escaped when it's passed to the GtkCellRendererText. /var/log/gdm/:0-greeter.log contains many errors like: > gdm-simple-greeter[1189]: Gtk-WARNING: Failed to set text from markup > due to error parsing markup: Error on line 1, character 18 : > « Test&2< » isn't a valid name: « & » Real names can contain almost any char, so better escape the string with g_markup_printf_escaped() or g_markup_escape_text (). That's what I'm now doing in users-admin. (This is gdm 2.30.2 in Ubuntu 10.04.)
Created attachment 163360 [details] [review] Don't crash on markup parse failure
Created attachment 163361 [details] [review] Escape names before showing in markup
Thanks, Jon!
*** Bug 616584 has been marked as a duplicate of this bug. ***