After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624920 - [textoverlay] configurable text color and position
[textoverlay] configurable text color and position
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-21 12:50 UTC by Mark Nauwelaerts
Modified: 2010-08-09 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
textoverlay: configurable text color and position (9.22 KB, patch)
2010-07-21 12:50 UTC, Mark Nauwelaerts 		none Details | Review
textoverlay: configurable text color and position (9.27 KB, patch)
2010-07-22 15:37 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2010-07-21 12:50:02 UTC 
Created attachment 166277 [details] [review]
textoverlay: configurable text color and position

Rather than only left, right, top, etc, allow for horizontal and vertical positioning on a scale from 0 to 1. Also cater for configuring rendered text color.

Color is provided as xRGB value (as in bug #624919).
Comment 1 Sebastian Dröge (slomo) 2010-07-21 17:44:46 UTC 
Looks good but you could use a ARGB value, maybe people want to set the alpha of the test too.

Also textoverlay is drawing an outline and shadow, which will still be black.
Comment 2 Mark Nauwelaerts 2010-07-22 15:37:08 UTC 
Created attachment 166400 [details] [review]
textoverlay: configurable text color and position

As before, but allow for ARGB value as mentioned.

One might argue that a shadow (outline?) of whatever color is black, but if there are suggestions to arrive at another one ...
Comment 3 Sebastian Dröge (slomo) 2010-08-06 17:43:56 UTC 
Comment on attachment 166400 [details] [review]
textoverlay: configurable text color and position

Please commit, looks good :)
Comment 4 Mark Nauwelaerts 2010-08-09 08:01:28 UTC 
commit 90a79b4c604c354c0348312570f904fbbcc8130a
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Thu Jul 22 17:29:57 2010 +0200

    textoverlay: configurable text color and position
    
    Rather than only left, right, top, etc, allow for horizontal and vertical
    positioning on a scale from 0 to 1.
    Also cater for configuring rendered text color.
    
    Fixes #624920.
    
    API: GstTextOverlay:xpos
    API: GstTextOverlay:ypos
    API: GstTextOverlay:color