After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624919 - [videotestsrc] add solid color pattern
[videotestsrc] add solid color pattern
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-21 12:46 UTC by Mark Nauwelaerts
Modified: 2010-08-09 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videotestsrc: add solid-color pattern (8.72 KB, patch)
2010-07-21 12:46 UTC, Mark Nauwelaerts
none Details | Review
videotestsrc: add solid-color pattern (14.18 KB, patch)
2010-07-22 15:35 UTC, Mark Nauwelaerts
committed Details | Review

Description Mark Nauwelaerts 2010-07-21 12:46:53 UTC
Created attachment 166276 [details] [review]
videotestsrc: add solid-color pattern

... which generalizes the current listing of black, white, etc

Color is set as a big-endian xRGB provided guint32, which might be considered elegantly simply or hackish.  Maybe it is already done otherwise elsewhere, or should deserve a type of its own (comparable to fourcc), or ...
Comment 1 David Schleef 2010-07-21 19:57:24 UTC
Cool.

I've wanted to do something like this for a while.  Mostly, I wanted to replace white/black in most of the patterns with a foreground/background color, and then add properties for foreground and background color.
Comment 2 Sebastian Dröge (slomo) 2010-07-22 07:12:44 UTC
Same comment as in the other bug... why restrict yourself to xRGB. For ARGB/AYUV formats the alpha value would make sense too :)
Comment 3 Mark Nauwelaerts 2010-07-22 15:35:32 UTC
Created attachment 166398 [details] [review]
videotestsrc: add solid-color pattern

As before, but allow for ARGB value as mentioned.
Comment 4 Mark Nauwelaerts 2010-08-09 08:01:25 UTC
commit be6fb6e747dc10da111f15c2e897363c8a4051a9
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Jul 21 14:20:03 2010 +0200

    videotestsrc: add solid-color pattern
    
    ... which generalizes the current listing of white, black, etc.
    In particular, also allow specifying alpha channel, and modify
    some structures and pattern filling to cater for alpha value as well.
    
    Fixes #624919.
    
    API: GstVideoTestSrc:solid-color