After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624879 - Remove GTK (>=2.22) deprecated GtkNotebookPage symbols
Remove GTK (>=2.22) deprecated GtkNotebookPage symbols
Status: RESOLVED FIXED
Product: epiphany-extensions
Classification: Deprecated
Component: general
master
Other Linux
: Normal normal
: ---
Assigned To: epiphany-extensions-maint
epiphany-extensions-maint
Depends on:
Blocks: 624653
 
 
Reported: 2010-07-20 21:56 UTC by Mario Sánchez Prada
Modified: 2010-08-10 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch proposal (1.34 KB, patch)
2010-07-20 22:00 UTC, Mario Sánchez Prada 		none Details | Review
Patch proposal (1.34 KB, patch)
2010-07-20 22:18 UTC, Mario Sánchez Prada 		committed Details | Review

Description Mario Sánchez Prada 2010-07-20 21:56:52 UTC 
In the following files:

extensions/adblock/adblock-ui.c
extensions/adblock/ephy-adblock-extension.c

It would be needed to replace the occurrences of GtkNotebookPage with gpointer, as GtkNotebookPage is deprecated from GTK 2.22 on.
Comment 1 Mario Sánchez Prada 2010-07-20 22:00:26 UTC 
Created attachment 166242 [details] [review]
Patch proposal

Ataching a patch to fix this issue.
Comment 2 Mario Sánchez Prada 2010-07-20 22:18:41 UTC 
Created attachment 166244 [details] [review]
Patch proposal

While working on bug 624878, I've realized that a better approach would be to replace GtkNotebookPage with GtkWidget instead of gpointer, so I'm attaching a new patch now with that (small) change.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2010-07-22 14:37:26 UTC 
Review of attachment 166244 [details] [review]:

Thanks! :)
Comment 4 Mario Sánchez Prada 2010-08-10 09:10:26 UTC 
(In reply to comment #3)
> Review of attachment 166244 [details] [review]:
> 
> Thanks! :)

I don't have commit permission. Could you please commit it for me?

Thanks!
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2010-08-10 17:01:17 UTC 
Committed with a few additions. Thanks Mario.