GNOME Bugzilla – Bug 624878
Remove GTK (>=2.22) deprecated symbols
Last modified: 2010-08-30 20:50:21 UTC
Currently, in the following files (at least in the gnome-2-30 branch): src/bookmarks/ephy-bookmark-action.c src/bookmarks/ephy-bookmark-properties.c src/bookmarks/ephy-topic-action.c src/ephy-link-action.c src/ephy-location-action.c src/ephy-notebook.c src/ephy-window.c src/pdm-dialog.c There are several occurrences of the GtkNotebookPage symbol (which should be replaced by gpointer) and the gtk_button_{press|release}() functions, which are deprecated from GTK 2.22 on. So it would be needed to replace them for the proper replacement code.
Created attachment 166241 [details] [review] Patch proposal Attaching a patch proposal to fix this issue. Not 100% sure but I'd bet this patch is also valid for the master branch.
(In reply to comment #1) > Created an attachment (id=166241) [details] [review] > Patch proposal > > Attaching a patch proposal to fix this issue. Not 100% sure but I'd bet this > patch is also valid for the master branch. I need to sleep :-). Actually, this patch is for code currently in master branch, as ephy 2.30 doesn't require GTK 2.22 so that wouldn't be strictly needed in that version. Hence, changing version and uploading a new patch compiling against that branch (where there was already part of the work done)
Created attachment 166243 [details] [review] Patch proposal (for master, aka 2.31.x series) (In reply to comment #2) > [...] > Actually, this patch is for code currently in master branch, as ephy 2.30 > doesn't require GTK 2.22 so that wouldn't be strictly needed in that version. > > Hence, changing version and uploading a new patch compiling against that branch > (where there was already part of the work done) Here is the new patch, which just replaces the gtk_button_pressed() and gtk_button_released() functions with the equivalent code, as the GtkNotebookPage issue was already fixed in master prior to this (so forget about that part in this bug's description.
Comment on attachment 166241 [details] [review] Patch proposal So... the GtkNotebook stuff was already done by Diego on master (the correct thing to do is change them to GtkWidget AFAIK, not gpointer). There is no replacement for the other deprecated functions, and the change you are doing is not correct. You are the third person that attemps to do this exact same patch FWIW, after me and Javier Jardón I think :D See bug 610515 for details on that.
(In reply to comment #4) > (From update of attachment 166241 [details] [review]) > So... the GtkNotebook stuff was already done by Diego on master (the correct > thing to do is change them to GtkWidget AFAIK, not gpointer). After talking to Xan by IM we agreed that these changes should be as well in the 2.30.x branch (even though they are already in master branch), as they're backward compatible and therefore wouldn't hurt at all. Hence resetting version to 2.30.x once again (ping? pong!), so we can at least get that part in for gnome-2-30 branch. > There is no replacement for the other deprecated functions, and the change you > are doing is not correct. You are the third person that attemps to do this > exact same patch FWIW, after me and Javier Jardón I think :D Damm it, thanks for the info. > See bug 610515 for details on that. Thanks for the pointer
Created attachment 166245 [details] [review] Patch proposal (for 2.30.x branch) Here we come again... good night!
Review of attachment 166245 [details] [review]: Looks good to me.
(In reply to comment #7) > Review of attachment 166245 [details] [review]: > > Looks good to me. I don't have commit permission. Could you please commit it for me? Thanks!
I'll push a gnome-2-30 update that includes this and other fixes. :D