After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624350 - Toolbar Editor is throwing gtk-critical messages
Toolbar Editor is throwing gtk-critical messages
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-14 15:13 UTC by Jorge Kalmbach
Modified: 2010-08-30 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
replaces the fake_expose_widget method with a combination of the gtk_offscreen_window and gtk_widget_get_snapshot method. (3.68 KB, patch)
2010-07-14 15:13 UTC, Jorge Kalmbach 		none Details | Review
refactored new_pixbuf_from_widget using gtk_offscreen_window (4.03 KB, patch)
2010-07-14 20:52 UTC, Jorge Kalmbach 		none Details | Review
egg-editable-toolbar: use gtk_offscreen_window to draw widgets (3.93 KB, patch)
2010-08-30 18:50 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Jorge Kalmbach 2010-07-14 15:13:11 UTC 
Created attachment 165885 [details] [review]
replaces the fake_expose_widget method with a combination of the gtk_offscreen_window and gtk_widget_get_snapshot method.

Toolbar Editor is throwing the following error:

Gtk-CRITICAL **: gtk_widget_set_window: assertion `window == NULL ||
GDK_IS_WINDOW (window)' failed.

I debugged the problem and it happens during the creation of the
Toolbar Separator pixbuf

I attached a patch that fixes this by replacing the fake_expose_widget
method with a combination of the gtk_offscreen_window and
gtk_widget_get_snapshot method.
Comment 1 Christian Persch 2010-07-14 19:53:39 UTC 
The copy of toolbar-editor in evince already is fixed for this, it just needs to be applied upstream in libegg and then applied to epiphany.
Comment 2 Jorge Kalmbach 2010-07-14 20:52:02 UTC 
evince approach is better, i used it to create a new patch.

Can this be applied to epiphany now or have we to wait for a new version of libegg?
Comment 3 Jorge Kalmbach 2010-07-14 20:52:59 UTC 
Created attachment 165919 [details] [review]
refactored new_pixbuf_from_widget using gtk_offscreen_window
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 18:50:09 UTC 
Created attachment 169114 [details] [review]
egg-editable-toolbar: use gtk_offscreen_window to draw widgets

Shuts up warnings when using the toolbar editor.

Bug #624350
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 18:53:05 UTC 
Neither Carlos nor Jorge's patch apply to libegg master, I recreated the patch here. I'd like to push it to libegg before epiphany updates its libegg copy (bug #580557). Anyone knows who keeps an eye on libegg or is it free for all?
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2010-08-30 21:02:45 UTC 
Ok. So I committed this in libegg master and then updated epiphany's libegg copy. Everything's nice now :).

Thanks!