GNOME Bugzilla – Bug 580557
Resync with libegg to remove deprecated GTK+ symbols
Last modified: 2010-08-30 19:43:52 UTC
Epiphany uses the deprecated gtk_widget_get_action in copy-pasted code from ligegg: lib/egg/egg-editable-toolbar.c:203: action = gtk_widget_get_action (widget); lib/egg/egg-editable-toolbar.c:229: action = gtk_widget_get_action (widget); lib/egg/egg-editable-toolbar.c:500: GtkAction *action = gtk_widget_get_action (GTK_WIDGET (item)); The replacement gtk_activatable_get_related_action requires gtk 2.16 and libegg has added a check to use it if the available gtk version is high enough. You should resync with libegg to get that code. The relevant commit it here: http://git.gnome.org/cgit/libegg/commit/?id=3262b337f4527d0397032a6094de7b0c9e4ad3a5
Heh. Also talked about this with Xan on IRC two days ago.
Done in commit dcae8dfd69b1052907b94fc300537a20999938dc, thanks.
Created attachment 151080 [details] [review] Substitute gtk_button_pressed() and gtk_button_released()
Sorry, I reopened this bug because epiphany has some newly deprecated symbols
(In reply to comment #3) > Created an attachment (id=151080) [details] [review] > Substitute gtk_button_pressed() and gtk_button_released() This patch is wrong (I should know, I committed something identical just to find it was broken). Those functions only get you the *visual effect* a press/release, which is what epiphany needs, not the actual event (and btw, the event is missing in the signal emission). If you feed an event you'll get epiphany in an infinite loop, since this is being done as the result of a press/release event too. The context is that we want to do actions on middle click on the toolbar buttons, but GtkButton does not react to middle click, so we catch the button-{press,release}-events manually and then fake the visual effect by calling those functions. I guess the good fix would be changing GtkButton to react to the middle button.
Any plans to fix this / update the patch?
Can this please be handled this week? It is planned to ship GNOME 2.31.4 with gtk 2.90 hence it is required to fix / work around this.
Our copy of libegg needs an update again. I'll give it a look soonish.
Created attachment 169111 [details] [review] lib/egg: update scripts Bug #580557
Created attachment 169112 [details] [review] lib/egg: update to libegg master Bug #580557
Created attachment 169119 [details] [review] lib/egg: update to libegg master I just committed two more fixes to libegg master. This new patch includes them.
I think we have another bug for the pressed/released issue. I'll open a bug for it otherwise. This is already a bit polluted. Attachment 169111 [details] pushed as 333aeb8 - lib/egg: update scripts Attachment 169119 [details] pushed as 6316dcb - lib/egg: update to libegg master