After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622790 - use standalone gdk-pixbuf
use standalone gdk-pixbuf
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
: 599803 618475 (view as bug list)
Depends on: 622792
Blocks:
 
 
Reported: 2010-06-26 11:11 UTC by Christian Persch
Modified: 2010-06-27 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove XEMBED support from rsvg-view (4.08 KB, patch)
2010-06-26 13:07 UTC, Christian Persch
accepted-commit_now Details | Review
Use standalone gdk-pixbuf (19.39 KB, patch)
2010-06-26 13:08 UTC, Christian Persch
accepted-commit_now Details | Review

Description Christian Persch 2010-06-26 11:11:56 UTC
we can go back to just producing librsvg-2 and just dual-build the gtk module.

I'm working on a patch.
Comment 1 Christian Persch 2010-06-26 13:07:50 UTC
Created attachment 164676 [details] [review]
Remove XEMBED support from rsvg-view
Comment 2 Christian Persch 2010-06-26 13:08:04 UTC
Created attachment 164677 [details] [review]
Use standalone gdk-pixbuf

Go back to just building one librsvg, using the standalone
gdk-pixbuf-2.0.

Bug #622790.
Comment 3 Christian Persch 2010-06-26 13:52:47 UTC
*** Bug 599803 has been marked as a duplicate of this bug. ***
Comment 4 Christian Persch 2010-06-26 18:07:22 UTC
*** Bug 618475 has been marked as a duplicate of this bug. ***
Comment 5 Hiroyuki Ikezoe 2010-06-27 11:57:06 UTC
Review of attachment 164677 [details] [review]:

Please commit with fix for the following issue.

::: configure.in
@@ +280,3 @@
+  if test "x$GDK_PIXBUF_QUERYLOADERS" = "xnone"; then
+    AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none])
+  fi

This part does not work expectedly because the first result of AC_PATH_PROG sets "none" in its result, so the next AC_PATH_PROG uses "none" as its cached result if standalone gdk-pixbuf is not installed.

So the part should be:

  AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders-2.0])

  if test "x$GDK_PIXBUF_QUERYLOADERS" = "x"; then
    AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none])
  fi

Other parts looks pretty good to me.
Comment 6 Hiroyuki Ikezoe 2010-06-27 11:58:14 UTC
Comment on attachment 164676 [details] [review]
Remove XEMBED support from rsvg-view

Commit, please.
Comment 7 Christian Persch 2010-06-27 12:23:14 UTC
(In reply to comment #5)
> Review of attachment 164677 [details] [review]:
> 
> Please commit with fix for the following issue.
> 
> ::: configure.in
> @@ +280,3 @@
> +  if test "x$GDK_PIXBUF_QUERYLOADERS" = "xnone"; then
> +    AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none])
> +  fi
> 
> This part does not work expectedly because the first result of AC_PATH_PROG
> sets "none" in its result, so the next AC_PATH_PROG uses "none" as its cached
> result if standalone gdk-pixbuf is not installed.
> 
> So the part should be:
> 
>   AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders-2.0])
> 
>   if test "x$GDK_PIXBUF_QUERYLOADERS" = "x"; then
>     AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none])
>   fi

Actually this part isn't needed anymore, since the standalone gdk-pixbuf switched back to using gdk-pixbuf-query-loaders without -2.0 suffix.
Comment 8 Christian Persch 2010-06-27 17:42:31 UTC
Pushed to master with a few follow-up fixes I found when trying to build against an older in-gtk gdk-pixbuf.