GNOME Bugzilla – Bug 622790
use standalone gdk-pixbuf
Last modified: 2010-06-27 17:42:31 UTC
we can go back to just producing librsvg-2 and just dual-build the gtk module. I'm working on a patch.
Created attachment 164676 [details] [review] Remove XEMBED support from rsvg-view
Created attachment 164677 [details] [review] Use standalone gdk-pixbuf Go back to just building one librsvg, using the standalone gdk-pixbuf-2.0. Bug #622790.
*** Bug 599803 has been marked as a duplicate of this bug. ***
*** Bug 618475 has been marked as a duplicate of this bug. ***
Review of attachment 164677 [details] [review]: Please commit with fix for the following issue. ::: configure.in @@ +280,3 @@ + if test "x$GDK_PIXBUF_QUERYLOADERS" = "xnone"; then + AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none]) + fi This part does not work expectedly because the first result of AC_PATH_PROG sets "none" in its result, so the next AC_PATH_PROG uses "none" as its cached result if standalone gdk-pixbuf is not installed. So the part should be: AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders-2.0]) if test "x$GDK_PIXBUF_QUERYLOADERS" = "x"; then AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none]) fi Other parts looks pretty good to me.
Comment on attachment 164676 [details] [review] Remove XEMBED support from rsvg-view Commit, please.
(In reply to comment #5) > Review of attachment 164677 [details] [review]: > > Please commit with fix for the following issue. > > ::: configure.in > @@ +280,3 @@ > + if test "x$GDK_PIXBUF_QUERYLOADERS" = "xnone"; then > + AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none]) > + fi > > This part does not work expectedly because the first result of AC_PATH_PROG > sets "none" in its result, so the next AC_PATH_PROG uses "none" as its cached > result if standalone gdk-pixbuf is not installed. > > So the part should be: > > AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders-2.0]) > > if test "x$GDK_PIXBUF_QUERYLOADERS" = "x"; then > AC_PATH_PROG([GDK_PIXBUF_QUERYLOADERS],[gdk-pixbuf-query-loaders],[none]) > fi Actually this part isn't needed anymore, since the standalone gdk-pixbuf switched back to using gdk-pixbuf-query-loaders without -2.0 suffix.
Pushed to master with a few follow-up fixes I found when trying to build against an older in-gtk gdk-pixbuf.