GNOME Bugzilla – Bug 621753
Should be able to build with GTK+3
Last modified: 2010-07-08 13:11:01 UTC
Empathy 2.32/3.0 should be able to build with GTK+3 but I'd like keep 2.22 compat for this cycle. Here is what I suggest: - During configure, check if GTK+3 is present. - If it is we requiers GTK3 flavour of the deps (webkit-gtk, etc) - If not we depends on GTK+ 2.22 and requiers GTK2 flavours of the deps That means we should NOT use any GTK+3 specifc API in this cycle. If we can easily #idef it maybe we could use GtkApplication instead of libunique-3 but let's discuss that in bug #621339 Next cycle (3.1) we'll hard depend on GTK+3.
*** Bug 623199 has been marked as a duplicate of this bug. ***
Created attachment 165464 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gtk3-621753 configure.ac | 168 ++++++++++++---------- extensions/Makefile.am | 2 +- libempathy-gtk/Makefile.am | 8 +- libempathy-gtk/empathy-notify-manager.h | 2 + libempathy/Makefile.am | 4 +- nautilus-sendto-plugin/Makefile.am | 3 +- nautilus-sendto-plugin/empathy-nautilus-sendto.c | 17 +++ src/Makefile.am | 6 + src/empathy-call-window.c | 4 +- tests/interactive/Makefile.am | 4 +- 10 files changed, 131 insertions(+), 87 deletions(-)
Note that the GTK3 version doesn't actually run because of bug #623811 but I think it's worth merging it anyway to avoid letting the branch rot and conflict. We can easily build using GTK2 even if GTK3 is installed by passing --enable-gtk3=no.
(In reply to comment #3) > Note that the GTK3 version doesn't actually run because of bug #623811 That was actually an Empathy bug which is fixed now.
Review of attachment 165464 [details] [review]: ++
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.