After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621339 - Port Empathy to GtkApplication
Port Empathy to GtkApplication
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 621753 623925 630025
Blocks:
 
 
Reported: 2010-06-12 01:34 UTC by Danielle Madeley
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gtk-application-621339 (25.54 KB, patch)
2010-10-15 13:39 UTC, Guillaume Desmottes
reviewed Details | Review

Description Danielle Madeley 2010-06-12 01:34:29 UTC
libunique is not going to be available for GTK+ 3.0, so we should port Empathy to GtkApplication.
Comment 1 Guillaume Desmottes 2010-06-15 11:41:05 UTC
If possible I'd really like to keep GTK 2.22 compat for this cycle. Would be good if we could detect at configure time if we have GTK3 and if not fallback to libunique.
Comment 2 Xavier Claessens 2010-06-15 12:18:52 UTC
There is going to have libunique-3, so there is no need of GtkApplication actually... I'm in favor to wait for 3.1 to hard-dep on gtk3.
Comment 3 Guillaume Desmottes 2010-06-16 11:11:23 UTC
First, let's allow Empathy to build with GTK+3: bug #621753
Comment 4 Guillaume Desmottes 2010-07-09 10:08:36 UTC
We are using libunique-3 when buidling with GTK+3. We'll switch to GtkApplication once we'll hard dep on GTK+3 (bug #623925).
Comment 5 Guillaume Desmottes 2010-10-15 13:39:07 UTC
Created attachment 172420 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gtk-application-621339

 configure.ac                  |    2 -
 src/Makefile.am               |    4 -
 src/empathy-accounts-common.c |    1 -
 src/empathy-accounts.c        |   53 +----
 src/empathy-av.c              |    8 +-
 src/empathy-debugger.c        |    9 +-
 src/empathy.c                 |  484 +++++++++++++++++++++++++----------------
 7 files changed, 325 insertions(+), 236 deletions(-)
Comment 6 Danielle Madeley 2010-10-18 04:27:51 UTC
Review of attachment 172420 [details] [review]:

Looks good. Ship it!
Comment 7 Guillaume Desmottes 2010-10-18 08:16:26 UTC
Thanks for the review.

Merged, will be in 2.91.1.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.