GNOME Bugzilla – Bug 621339
Port Empathy to GtkApplication
Last modified: 2011-08-29 10:12:43 UTC
libunique is not going to be available for GTK+ 3.0, so we should port Empathy to GtkApplication.
If possible I'd really like to keep GTK 2.22 compat for this cycle. Would be good if we could detect at configure time if we have GTK3 and if not fallback to libunique.
There is going to have libunique-3, so there is no need of GtkApplication actually... I'm in favor to wait for 3.1 to hard-dep on gtk3.
First, let's allow Empathy to build with GTK+3: bug #621753
We are using libunique-3 when buidling with GTK+3. We'll switch to GtkApplication once we'll hard dep on GTK+3 (bug #623925).
Created attachment 172420 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gtk-application-621339 configure.ac | 2 - src/Makefile.am | 4 - src/empathy-accounts-common.c | 1 - src/empathy-accounts.c | 53 +---- src/empathy-av.c | 8 +- src/empathy-debugger.c | 9 +- src/empathy.c | 484 +++++++++++++++++++++++++---------------- 7 files changed, 325 insertions(+), 236 deletions(-)
Review of attachment 172420 [details] [review]: Looks good. Ship it!
Thanks for the review. Merged, will be in 2.91.1. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.