GNOME Bugzilla – Bug 621535
User should be able to select date and time format from gui.
Last modified: 2010-09-20 10:55:34 UTC
bgo#611576 implements the presentation of date and time when user presses a shortcut key. In settings.py we have several formats that the user can select between. Currently the user is able to switch format by editing their orca-customizations.py. s/he should be able to select the formatting strings from combo boxes. From Joanie's comment bgo#611576#c31 "I think it would be cool to have a combo box which allowed the user to select the desired format from a list containing the sample date and the sample time as it would be spoken and brailled (i.e. in the local language of the user)." Thanks.
Deepak, this might be intresting for you to get started on. Assigning it to you *thumbs up*
CHeers Jon
Joanie, do you want the combo boxes in the general tab? Dont fit within speech or braille, since it is consering both. Thanks.
I don't see where else they could go other than the general tab.
OK guys, i am done with this bug. Jon i have sent you an email regarding this. So i think i cant change the status to resolved. I will leave it till friday. if any one finds any bugs, please approach.
Bugs are not 'resolved' until the patch has been committed. Where is the patch, by the way? Please attach it to this bug. Thanks!
Deepak, we dont close the bug until Joanie has seen the patch, and it has been commited to master. Before that, there are a few more issues I need you to look at before we attach the patch and ask for Joanies review. you need to pylint, also clean up the glade file, because you have the same issue as Tom has, (read comment 40 of bug 536827, the nits section, point 4). @Joanie, I set up a remote git source, on one of the servers, so that I can give Deepak and Tom a place where they can commit to for my review and comment, while they get up to speed, before we attach the final patch to bugzilla. Thanks.
Created attachment 164652 [details] [review] [patch] for bgo#621535 - User should be able to select date and time format from gui. Joanie, does this look reasonable? Thanks.
Review of attachment 164652 [details] [review]: I think we should try to be consistent in the appearance of the widgets in the Orca Preferences dialog. If you look at the combo boxes on any of the other pages in the Preferences dialog you'll see: * The label for combo boxes is immediately to the left of the combo box; not above it. * The label for combo boxes is not bold. * The label for combo boxes, when possible, has an underlined letter so one can jump immediately to the desired widget. That should be possible on the General page since there are not that many widgets on it. In terms of the label text itself, I don't think we need the word 'Present' in there. 'Date format' and 'Time format' should suffice. Also, translator notes should be added for those labels. Now that I'm seeing the date and not just hearing it, I noticed that there's an extra (unwanted) comma in between the number for the day (26) and the month (June). That's not part of this bug/rfe per se; but this rfe makes the issue much more visible. So I think it would be good to get rid of that comma. On a related note, now that I see what all of my choices are, it's more obvious to me that I can choose '26 June' but not 'June 26'. Since I prefer '26 June', that's not a problem. But most Americans will likely prefer 'June 26' and wonder why it's not there. So perhaps we should also use this rfe as an opportunity to add some additional formats. (Either as part of this rfe or separately). Getting back to the patch itself, nits: * The text which describes what a method does belongs in the docstring; not as a comment. * We should try to limit comments to two things: Translator notes and explanations for why we did something unusual (e.g. to hack around a bug) and might otherwise forget the next time we looked at the code. Otherwise, we should be able to tell from the code itself what something is and/or does. Thus these sorts of comments should be removed: #This combo box is used to change the date format for the users #available in the general tab dateFormatCombo = widget.get_active() * For any comments that should be kept: We put one space after the '#' and before the text of a comment. We indent comments with the block of the code to which they apply. And we typically have a final '#' as the last line of the comment. (To be honest, I'm not sure why we've done the final '#' but I think it's nice to be consistent with the established conventions.) * Adding a single blank line to separate blocks of code is fine and often helpful. Three to six blank lines is excessive.
Sorry for the spam. I forgot to mention something else: The combo boxes should not occupy the full width of the Preferences dialog (which is a really, really wide dialog box).
Created attachment 164855 [details] [review] Rev 2. [patch] for bgo#621535 - User should be able to select date and time format from gui. Joanie, Please find Deepak's second patch. The extra comma in the date format, and the additional date format option will probably be a new RFE, I am sure Deepak will take it on :) Pylinted to 10.0 Thanks.
*** Bug 623098 has been marked as a duplicate of this bug. ***
Jon, Deepak, I tested the second patch, works for me right. Thank you the combobox labels translation markup.
(In reply to comment #11) > The extra comma in the date format, and the additional date format option > will probably be a new RFE, I am sure Deepak will take it on :) The extra comma is a nit, but it's a bug from the original implementation; not an RFE. And one which is only made more apparent by the implementation of this RFE. I'd like to see Deepak's work committed, therefore, I've fixed the comma issue.
Thanks Joanie. Deepak, I have commited the patch to master. Please mark this as resolved, fixed, and thanks for your first contribution to the project.