After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536827 - Provide configuration GUI option to set the Orca key/modifier
Provide configuration GUI option to set the Orca key/modifier
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal enhancement
: 2.32.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-05 15:30 UTC by Willie Walker
Modified: 2010-09-20 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
initial Patch to provide combobox for orcaModifierKeys (7.93 KB, patch)
2008-07-12 00:54 UTC, Mesar Hameed
none Details | Review
Screenshot with current area highlighted in red (80.58 KB, image/png)
2008-08-01 12:57 UTC, Willie Walker
  Details
Combo-box solution, with known safe modifiers. (7.06 KB, patch)
2008-08-01 15:08 UTC, Mesar Hameed
none Details | Review
screenshot with checkboxes. (114.55 KB, image/x-png)
2008-08-03 23:34 UTC, Mesar Hameed
  Details
patch for the above gui, and a proposed solution for the bug. (15.14 KB, patch)
2008-08-03 23:53 UTC, Mesar Hameed
reviewed Details | Review
revision 4 (13.00 KB, patch)
2008-12-28 00:50 UTC, Mesar Hameed
needs-work Details | Review
This is the hungarian screen picture. (593.67 KB, image/png)
2009-02-07 12:03 UTC, Hammer Attila
  Details
This is the english screen picture. (781.36 KB, image/png)
2009-02-07 12:07 UTC, Hammer Attila
  Details
patch, still gives console warnings. (33.22 KB, patch)
2009-02-25 10:42 UTC, Mesar Hameed
needs-work Details | Review
master compatible version of the last patch. (26.93 KB, patch)
2010-06-11 17:25 UTC, Mesar Hameed
none Details | Review
Master compatible version, with improved gui. (34.46 KB, patch)
2010-06-11 20:46 UTC, Mesar Hameed
needs-work Details | Review
Incomplete patch for bgo#536827 - Provide configuration GUI option to set the Orca key/modifier (19.59 KB, patch)
2010-07-05 08:41 UTC, Mesar Hameed
none Details | Review
KISS principle fix (6.64 KB, patch)
2010-07-10 22:41 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Willie Walker 2008-06-05 15:30:33 UTC
Right now, users need to hand edit their user-settings.py or orca-customizations.py files to redefine the Orca modifier.  Users want to be able to use the configuration GUI to do this.

A proposed solution is to modify the "Orca Modifier Keys" control of the "Key Bindings" tab to be a combobox containing these items:

Insert and KP_Insert (default)
Insert
KP_Insert
Caps Lock
Left Alt
Right Alt
Left Control
Right Control
Comment 1 Jonathan Chacón 2008-06-05 16:04:37 UTC
alt+control or shift+alt must be added
Comment 2 Bertil Smark Nilsson 2008-06-09 11:42:44 UTC
I do think that the Widows keys should be included, since they won't conflict with any other function.
Comment 3 Bertil Smark Nilsson 2008-06-11 02:56:53 UTC
I did mean Windows keys
Comment 4 Mesar Hameed 2008-07-11 20:15:39 UTC
looking into it

Thanks
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-07-11 20:29:09 UTC
Awesome.  Thanks!
Comment 6 Mesar Hameed 2008-07-12 00:54:13 UTC
Created attachment 114425 [details] [review]
initial Patch to provide combobox for orcaModifierKeys

This patch:

As per Will's request, the text entry on the keybindings tab has been changed to a combobox.
The combobox provides:
Insert+KP_Insert
Insert
KP_Insert
Caps_Lock
Left Alt 
Right Alt 
Left Control 
Right Control
Left Windows (Super_L)
Right Windows
Both Windows

Currently only have access to laptop, so could not check the functionality for all the keys, but:
Left Alt: + space gives minimize/maximize menu.
left Control: indeed the control is being used as an orca key, but it is also being picked up as being control, so when pressing this with space, we get the application specific preferences.
xev said Super_L, but i cant seem to use it as an orca key, had to manually change usersettings.py and restarting orca.

Please test, and confirm/deny which keys work.

This patch also disconnects the keyboard layout from the orcaModifierKeys.

Thank you
Comment 7 Mesar Hameed 2008-07-12 01:02:41 UTC
sorry forgot to pylint, but will do once things are more discussed.
Comment 8 Mesar Hameed 2008-07-26 17:38:27 UTC
Hello, its me again :)

ISO_Level3_Shift seems to be the only working non-clashing key that could be used as an orcamodifier.

Tested with desktop machine, and both Super_L and Super_R doesnt seem to work.
Did anyone get these to work previously?

Proposed combo of modifier keys:
Insert+KP_Insert (default)
Insert
KP_Insert
Caps_Lock
ISO_Level3_Shift

Are these choices sufficient?

Thank you
Comment 9 Mike Pedersen 2008-07-30 14:47:17 UTC
Just a comment on the user interface for this feature.  I'd like to see this implemented as a list of checkable items.  This will make it easy for a user to select several modifiers.   
Comment 10 Mesar Hameed 2008-08-01 11:48:36 UTC
Will, Mike's suggestion is a good one for a braille/speech user, but might the multiple options take too much screenspace/be confusing for magnification users?
Comment 11 Willie Walker 2008-08-01 12:48:21 UTC
I think what Mike is suggesting is what would look a bit like a popup list or menu containing check items.  As such, it would take up very little screen real estate.  The only thing that worries me about this approach is that it might be misleading to the user who is able to see the list -- if only one item were shown when it was in the un-popped up state, the user might not get the complete story.

I'm adding Calum Benson to the CC list on this -- he's a good guy with good UI ideas.  Calum can you help?  (I'll attach a screen shot of the current UI)
Comment 12 Willie Walker 2008-08-01 12:57:36 UTC
Created attachment 115678 [details]
Screenshot with current area highlighted in red

In this screenshot, the area we're trying to fix is highlighted in red (I did it with gimp - we don't ship it that way ;-)).  The text area is currently uneditable.  Right now, the only choices are provided by selecting "Desktop" or "Laptop" layout on the "General" tab.  You get what you get and the choices are exclusive. 

We're looking for suggestions for allowing the user to have more control over the Orca modifier keys.  Some users, for example, want to have the Caps Lock (what you get with the laptop layout) *and* the KP_Insert/Insert (what you get with the desktop layout) keys.  Others want to co-opt the "Windows" and other keys for this purpose.
Comment 13 Mesar Hameed 2008-08-01 15:08:52 UTC
Created attachment 115692 [details] [review]
Combo-box solution, with known safe modifiers.

Attached it here, before I misplace the patch.
pylints to 10.00

the windows keys didnt work as modifier keys on my two machines, will see if anyone had them working on the mailinglist.

Thanks
Comment 14 Joanmarie Diggs (IRC: joanie) 2008-08-01 20:15:32 UTC
I just took a quick look.  What is interfering with the use of Super as the Orca modifier is its inclusion in settings.NON_LOCKING_MODIFIER_MASK (in the form of META3). Remove that from the group and Super works as the Orca modifier.

settings.NON_LOCKING_MODIFIER_MASK is the default set of modifiers we care about when identifying if a given keypress matches a given keybinding. We care about Super/META3 for a couple of reasons: 

1. Some OSes use it (e.g. OpenSolaris uses Super+d for the desktop and Super+r for the run application dialog). If we didn't attend to it, and, say, decided we'd bind 'r' for structural navigation by radio button, we'd be in danger of consuming Super+r thus preventing OpenSolaris users from getting to the run application dialog if Firefox had focus.

2. Right now users can bind commands using Super (e.g. they could make Super+h the command to move to the next heading in FF).

So, I wonder if the thing we need to do is figure out what the Orca modifier is and if it turns out to be one of the items in the NON_LOCKING_MODIFIER_MASK, remove it from the mask. (Note I haven't tried this, I'm just thinking out loud.)
Comment 15 Mesar Hameed 2008-08-03 23:34:16 UTC
Created attachment 115795 [details]
screenshot with checkboxes.

Joanie, Thank You, your suggestion was totally right, its working great now :)

Will, Mike, I was quite wrong, according to my brother (sighted) the interface does not look too cluttered with the additional checkboxes. Appologies for previous comment regarding this.

Please find attached screenshot of new gui.
Comment 16 Mesar Hameed 2008-08-03 23:53:41 UTC
Created attachment 115796 [details] [review]
patch for the above gui, and a proposed solution for the bug.

pylints to 10.00

1. pylint seems to be very upset about
if ("a" or "b") in list:
it says that it is invalid syntax, although it works fine in python console and in ipython, so ended up not using that syntax, is it me or pylint? :)

2. The above gui code also creates a warning, for the "Insert" checkbox, about having two associated labels, is there a way to eliminate this, or should it be ignored.
I associated the orca modifier key(s) label with the Insert checkbox so that the user would know what they were modifying. 

3. As Joanie suggested, when we notice "Super_L" or Super_R" in the orcaModifierKeys then we change the defaultModifierMask.

Please test.
Comment 17 Mike Pedersen 2008-08-05 00:10:19 UTC
Hi all, I just tested this.  I thought we decided to go with a checkable list.  This is just my preference but I'm not a fan of the checkboxes.  
Just my opinion 
Comment 18 Willie Walker 2008-08-05 15:07:20 UTC
I think this works pretty well and is definitely an improvement.  I'm a little concerned about the layout, however, especially when it comes to verbose languages such as German ("Pressun this button in order to performun a clicken action for the rectangularun Windows pressun key positioned to the leftun and not the rightun").

I'm not sure of a better way to do this, though.  Maybe another dialog box with a list of checkboxes in it?  The mechanism to bring up the dialog box might be a button whose name is a combination of the currently active Orca modifiers (e.g., the same text that we currently put in the uneditable text area).

Rather than placing the items statically in the *.glade file, I also wish there were a way to create the UI components more dynamically so as to allow us to more easily add/remove items in the future.  The way it is now is OK, though, but we'll need to take care to add comments for translators in the *.glade file.

In any case, many many thanks for your work and perseverance here.  It's a pleasure having a new contributor!
Comment 19 Willie Walker 2008-08-06 14:11:23 UTC
Just to follow up on this, I think the plan to move forward with this is to replace the existing uneditable text area on the "Key Bindings" page with a table that presents a list of checkboxes.  We'll try it out and see how it works.

Thanks Jon!  You're doing a lot of good work with Orca.
Comment 20 Mike Pedersen 2008-08-08 18:32:42 UTC
Just removing testing required until Jon is ready with a new patch.  
Comment 21 Willie Walker 2008-08-12 19:08:41 UTC
How are we doing with this bug?  UI freeze is this coming Monday, Aug 18.  I'd opt for getting the tutorial work done ahead of this.  In addition, in a worst case scenario, I'd be OK with pushing this one out to 2.26 if both the tutorial work and this one cannot be done by Monday.
Comment 22 Mesar Hameed 2008-08-13 04:59:08 UTC
im on it, hopefully we should have something to test shortly.

Appologies.
Comment 23 Willie Walker 2008-08-19 20:29:35 UTC
Moving to FUTURE since we're in UI freeze right now.  Jon - we'll get this in for 2.26!
Comment 24 Mesar Hameed 2008-12-28 00:50:08 UTC
Created attachment 125412 [details] [review]
revision 4

Good morning,

Comments welcome for the attached patch.

After applying the patch one needs to either:

remove ~/.orca/user-settings.py*
giving orca a chanse to rewrite the file from scratch.

or editing the same file (user-settings.py)
changing orca.settings.orcaModifierKeys to:
orca.settings.orcaModifierKeys = ['Insert', 'KP_Insert']

We have a new table in the key bindings tab, that allows for checking/unchecking a particular key, for the key to be used as an orca modifier key.

When the gui loads up, the list store seems to be giving off some gtk warnings, but i dont know what that is all about, the list is showing up perfectly fine.

Thank you.
Comment 25 Willie Walker 2009-01-13 19:00:21 UTC
(In reply to comment #24)
> Created an attachment (id=125412) [edit]
> revision 4

This is looking better.  Thanks Jon!  I think we might need to consider changing the key binding tab into two labeled panes: "Orca Modififer Keys" and "Bindings" (or something like that.  If we do that, the page might look better and we might be able to get away with not labeling the columns for the modifier keys.

I wish I knew my way around Glade better and could provide an update that shows what I'm talking about.

BTW, we definitely need to get to the bottom of the GTK error/warning messages that are emitted.  Something is odd there.  :-(

Thanks much for your work!
Comment 26 Hammer Attila 2009-02-07 12:03:30 UTC
Created attachment 128152 [details]
This is the hungarian screen picture.

This picture represent the entire speech page. Rate is setted up 75 (sebesség), pitch slider showing 5.0 (hangmagasság). I not change nothing, only navigating with speech page with right arrow and pressing one tab key.
Comment 27 Hammer Attila 2009-02-07 12:07:14 UTC
Created attachment 128153 [details]
This is the english screen picture.

This picture showing the speech page window. Not changing nothing, pitch slider showing 5.0 value but 0.0 was setted up since two day. See prewious comment.
Comment 28 Mesar Hameed 2009-02-25 10:42:29 UTC
Created attachment 129479 [details] [review]
patch, still gives console warnings.

Incomplete patch.

> WillieWalker1: The labels on the tables are centered and in lower case. They should be left justified and bold, like the "Text attributes" label on the "Text Attributes" tab.

done?

> WillieWalker1: I think they should also end up as labels for panels that contain the tables. That way, Orca will know to read them when you tab to the table.

Done

> WillieWalker1: The "Key Name" column is a bit narrow, cutting off the labels.

Done? (reasonable size)?

> WillieWalker1: The "is orca key" column probably should be retitled "Use as Orca Key" or something like that.

done

> WillieWalker1: The checkboxes in the "is orca key" column are centered in the column - it would be nice to make them left justified.

not done. (couldnt figure out how)


> WillieWalker1: If it were possible to shrink the "Orca Modifier Keys" table to only take up what's needed (or maybe just show 6 rows + the headers), it would be great.

Dont know how to.



Joanie, Could you please varify the things that I have done, and help with the things I dont know?

Also, any ideas on how to get rid of the warning messages that we get, I cant work out for my life why they are appearing.

Thanks much for your help.
Comment 29 Willie Walker 2009-03-18 00:16:56 UTC
OK - so, we need to make up our minds on this one.  I'm now wondering if a fixed list of modifiers is the right way to go, or if we should allow people to generate their own list, kind of like a combination of the pronunciation tab and the keybindings tab.  That is, have the add/remove functionality of the pronunciation tab to add a new Orca key and have the capture keystroke functionality of the keybindings to actually define the key.
Comment 30 Willie Walker 2009-03-29 21:27:04 UTC
(In reply to comment #29)
> OK - so, we need to make up our minds on this one.  I'm now wondering if a
> fixed list of modifiers is the right way to go, or if we should allow people to
> generate their own list, kind of like a combination of the pronunciation tab
> and the keybindings tab.  That is, have the add/remove functionality of the
> pronunciation tab to add a new Orca key and have the capture keystroke
> functionality of the keybindings to actually define the key.

PS - I apologize for this being a task along the lines of what my boss call a "fetch me a rock" activity.  http://www.urbandictionary.com/define.php?term=rock+fetch

It's not a pointless task per se, but I'm not sure we've really nailed this one down. From what I've seen, users may want to bind *any* key and any *set* of keys to the Orca modifier.  So, we probably need a way to support that.  Hence, the keystroke capture thought.
Comment 31 Mesar Hameed 2009-04-16 13:58:16 UTC
Hi Will,

I think giving them a large set of keys to choose from is probably sufficient (with checkboxes for multiple keys), because if they can choose any key that they wish, they might choose something that clashes with the system, and they would end up with something broken.

examples:
Left Alt: + space gives minimize/maximize menu.
left Control: indeed the control is being used as an orca key, but it is also
being picked up as being control, so when pressing this with space, we get the
application specific preferences.

there are probably others.

I am also conserned with how easy/hard it would be to get the right modifier mask.

ALL_BUT_NUMLOCK_MODIFIER_MASK
Comment 32 Steve Holmes 2009-06-25 05:25:40 UTC
After reading this whole thing from top to bottom for the first time, I think I rather liked the original combo box with predefined choices.  I personally can't think of that many different keys someone would want to use as an Orca modifier.  When people began talking about a list with checkable items or a list of checkboxes, I began to lose my place so to speak.

No matter what though, I feel the current default for the desktop layout should be changed to KP_Insert instead of both Insert keys.  I personally would never use the Insert key on the "six pack" as an Orca modifier.  I obviously can't speak for anyone else but this is my opinion thus far.  Even on laptops I've had any experience with, the insert key was never in a place where I would consider using it as an Orca key; I would use the caps lock key instead.
Comment 33 Willie Walker 2009-06-25 13:08:40 UTC
(In reply to comment #32)
> After reading this whole thing from top to bottom for the first time, I think I
> rather liked the original combo box with predefined choices.  I personally
> can't think of that many different keys someone would want to use as an Orca
> modifier.  When people began talking about a list with checkable items or a
> list of checkboxes, I began to lose my place so to speak.

There's also the idea of allowing you to set the Orca modifier key by just pressing the one you want to be the Orca modifier.  This seems much more flexible than restricting you to a set of predefined choices.  In addition, I have keys on my keyboard that I never press and I have no clue what they do or what they are bound to.  I know I can find the binding easily using xev and/or Orca debugging, but it would be much nicer if I didn't have to do this and were able to tell Orca "I don't know what the heck this key is, but I want you to use it as the Orca key."  Doing things this way also provides strong confirmation that the key you want to be the Orca modifier is what you think it is.

> No matter what though, I feel the current default for the desktop layout should
> be changed to KP_Insert instead of both Insert keys.  I personally would never
> use the Insert key on the "six pack" as an Orca modifier.  I obviously can't
> speak for anyone else but this is my opinion thus far.  Even on laptops I've
> had any experience with, the insert key was never in a place where I would
> consider using it as an Orca key; I would use the caps lock key instead.

Let's open this up to the Orca list for discussion.  If we reach a consensus among users that this is the way to go, we can get rid of the Insert key and stick with just the KP_Insert key.
Comment 34 Steve Holmes 2009-09-12 03:05:37 UTC
wHEN THIS WAS PUT UP FOR DISCUSSION ON THE LIST A WHILE BACK, i DID NOT RECALL SEEING VERY MANY RESPONSES ON THIS.  i STILL FEEL THE DEFAULT SHOULD BE CHANGED TO BE ONLY THE kp-iNSERT AND REMOVE THE OTHER INSERT KEY.  i NOTICE WITH THE LATEST git PULLS OF oRCA THAT BOTH INSERT KEYS ARE STILL USED AS AN oRCA KEY.
Comment 35 Willie Walker 2009-11-06 15:06:33 UTC
Review of attachment 129479 [details] [review]:

I think we still need to figure out the UI mechanism for this.  I'd opt for a table similar to the "key bindings" table where you can add a new entry and then press the key you would like to be the Orca modifier.  The table should allow for adding, removing, and reviewing each individual key set up to be the Orca modifier key.
Comment 36 Mesar Hameed 2010-06-11 17:25:00 UTC
Created attachment 163403 [details] [review]
master compatible version of the last patch.

Thanks Joanie :)
Not a code review, just if there is anything to do on the gui.
Comment 37 Mesar Hameed 2010-06-11 20:46:57 UTC
Created attachment 163432 [details] [review]
Master compatible version, with improved gui.

Thanks to Tom Reis!



Joanie, your feedback on this would be welcome.

Thanks.

-Jon
Comment 38 Joanmarie Diggs (IRC: joanie) 2010-06-13 01:22:12 UTC
Review of attachment 163432 [details] [review]:

Issues:

1. With this solution, it is possible (and quite simple) to have no Orca modifier keys. You just uncheck them all. If you combine that with a disabled Orca main window, you have no way to get back into Preferences and you have to use some other means to quit Orca. We need to prevent that from happening.

2. Related to the above: My keyboard doesn't have a right super key; only a left one. But it's possible for me to uncheck everything as a modifier and check just the right super key. Then I'm still without a modifier and still in the above boat. So I don't think the solution to issue 1 will be as simple as checking to be sure that there is at least one modifier selected. Additional validation will be needed.

3. I only gave this a quick functional spin (rather than dug into issues). However, when I selected the Left Super key and KP Insert as my two Orca modifiers, KP Insert worked as expected; Left Super didn't work as a modifier. So additional testing should be done here.

Nits:

1. I'd prefer to call the Super key the Super key and not the Windows key.

2. If we're going to be changing things here, I think now would be a good time to drop the use of "key(s)" rather than add another instance, i.e. "keybinding(s)". That convention to indicate singular and plural works well enough in English; less so for other languages. Let's just make stuff plural.

3. Visually, equally dividing the space allocated to the Orca modifiers versus keybindings looks odd to me. Since we're a screen reader, I'm less concerned about this than I might otherwise be. :-) Though for magnification users who prefer the mouse (and we do have some of those users), I'm not sure this allocation makes sense. Regardless.... The way in which these items were made to be re-sizable doesn't work as one might expect: You can give tons of space to the labels (which do not require more space), but it doesn't seem to allow you to give more space to the tables (for which one might want more space).

4. It seems as if your editor likes to remove the orientation property for vboxes. The problem with this is that some versions of Glade then display vboxes as if they were actually hboxes. While for many tasks I prefer to work directly with the xml and not in Glade, sometimes Glade winds up being easier. At least easier when the orientation property is correct. When I view the patched version of the setup dialog in Glade 3.6.7, it's a mess. :-( Therefore, if your editor insists on removing this property, when you're finished please go back and hand edit things so that this property remains in place.

Once the above are addressed, I think it would be worth it to get some user feedback and testing before committing this.
Comment 39 Steve Holmes 2010-06-13 16:41:48 UTC
I might offer one suggestion to safeguard against losing access to Orca's preferences panel.  If by chance all modifier keys get unchecked, then force the Orce control panel to be available, even if previously disabled.  This way if one realizes all Orca modifier keys are unavailable, you can still alt tab around to find Orca's panel.  This may be unprecedented behavior for GUI program configuration but sounds like an easy to keep from losing control altogether.
Comment 40 Joanmarie Diggs (IRC: joanie) 2010-06-13 16:50:34 UTC
It's a good idea Steve, but it still doesn't solve the case where I select a key that isn't valid (right Super, which doesn't exist on my keyboard) as my lone modifier.
Comment 41 Thomas REIS 2010-06-13 22:17:43 UTC
Hi

Would it it ok if we just removed the Super Right key since all the other keys are common accross all the keyboards whether this one is not

Cheers
 
Tom
Comment 42 Joanmarie Diggs (IRC: joanie) 2010-06-21 17:38:45 UTC
Jon, we don't need to do the 'name in the summary' field any more. The reason I'd not responded is primarily due to the fact that what I stated in Comment 38 and Comment 40 still stand: This still needs some serious validation. 

The removal of Super Right is okay unless some people want it as their modifier. Also, its removal is not sufficient to solve the other issues.
Comment 43 Mesar Hameed 2010-06-21 17:52:03 UTC
(In reply to comment #42)
Tom should have been more specific, saying that we have addressed the other issues.

(In reply to comment #38)
> Issues:
> 
> 1. With this solution, it is possible (and quite simple) to have no Orca
> modifier keys. You just uncheck them all. If you combine that with a disabled
> Orca main window, you have no way to get back into Preferences and you have to
> use some other means to quit Orca. We need to prevent that from happening.

done, by enabling the orca main window, and not allowing it to be checkbox for it to be unchecked.

> 2. Related to the above: My keyboard doesn't have a right super key; only a
> left one. But it's possible for me to uncheck everything as a modifier and
> check just the right super key. Then I'm still without a modifier and still in
> the above boat. So I don't think the solution to issue 1 will be as simple as
> checking to be sure that there is at least one modifier selected. Additional
> validation will be needed.
Right super key as been removed, and if a particular user wishes to have it, they can add it as an optional key in their settings.
> 3. I only gave this a quick functional spin (rather than dug into issues).
> However, when I selected the Left Super key and KP Insert as my two Orca
> modifiers, KP Insert worked as expected; Left Super didn't work as a modifier.
I will look into this, thought i had fixed that.

> Nits:
> 
> 1. I'd prefer to call the Super key the Super key and not the Windows key.
done
> 2. If we're going to be changing things here, I think now would be a good time
> to drop the use of "key(s)" rather than add another instance, i.e.
> "keybinding(s)". That convention to indicate singular and plural works well
> enough in English; less so for other languages. Let's just make stuff plural.
done
> 3. Visually, equally dividing the space allocated to the Orca modifiers versus
> keybindings looks odd to me. Since we're a screen reader, I'm less concerned
> about this than I might otherwise be. :-) Though for magnification users who
> prefer the mouse (and we do have some of those users), I'm not sure this
> allocation makes sense. Regardless.... The way in which these items were made
> to be re-sizable doesn't work as one might expect: You can give tons of space
> to the labels (which do not require more space), but it doesn't seem to allow
> you to give more space to the tables (for which one might want more space).
I believe Tom did this.
> 4. It seems as if your editor likes to remove the orientation property for
> vboxes. The problem with this is that some versions of Glade then display
> vboxes as if they were actually hboxes. While for many tasks I prefer to work
> directly with the xml and not in Glade, sometimes Glade winds up being easier.
> At least easier when the orientation property is correct. When I view the
> patched version of the setup dialog in Glade 3.6.7, it's a mess. :-( Therefore,
> if your editor insists on removing this property, when you're finished please
> go back and hand edit things so that this property remains in place.
Tom corrected this.

ok, I will look into the issue of left super, and provide new patch.
Comment 44 Joanmarie Diggs (IRC: joanie) 2010-07-04 23:49:09 UTC
Marking for '3.0?' as part of the planning for GNOME 3.

Also.... I think it's time to check in with the user community to find out what is truly needed with respect to providing a GUI way to set the Orca key. Therefore, I've emailed the Orca list: http://mail.gnome.org/archives/orca-list/2010-July/msg00019.html
Comment 45 Mesar Hameed 2010-07-05 08:41:26 UTC
Created attachment 165262 [details] [review]
Incomplete patch for bgo#536827 - Provide configuration GUI option to set the Orca key/modifier

Attaching the patch as it stands before I miss place it.

Joanie I believe the outstanding issue is the modifier for the super key, 
it use to work thanks to you informing me to remove meta3, somewhere along 
the line that is not happening now.

Unfortunately I will be away from end of today until after 2.31.5, so 
won't be able to track this one down.

On a personal note, I would prefer the checkboxes rather than the 
combobox.

Taking Into account the ongoing discussion, forgive me for assigning this 
one to you.

Thanks.
Comment 46 Joanmarie Diggs (IRC: joanie) 2010-07-10 22:41:18 UTC
Created attachment 165649 [details] [review]
KISS principle fix

The general consensus from the discussion of Orca users in response to my question [1] was in favor of keeping things simple and going with a combo box. I've done that here. Now users do not have to hand edit files to disable the Insert key and just use KP_Insert.

A few people on the list suggested that Super was worth doing. I'll take a brief, but deeper look into that issue. If I can sort it out quickly, I'll add it; if not, I'll open a new RFE and worry about it later.

I've tested this change quite a bit in multiple environments and versions of GNOME. Pylints to a 10.0. Committed to master.

http://git.gnome.org/browse/orca/commit/?id=c40e456ec8f7c32d5d7252904dc7f499ad9ec5ed

[1] http://mail.gnome.org/archives/orca-list/2010-July/msg00019.html
Comment 47 Steve Holmes 2010-07-11 01:17:12 UTC
I recently checked all possible combinations from the modifier key combo box and it appears to work as advertised.  One may note here that toggle keys used as modifiers such as caps-lock and insert, cannot be overridden with the Orca Bypass key (Orca+Backspace).  At least, it didn't work on my system.  But I think that issue has been in effect for a very long time.

Bottom line: the changes work.
Comment 48 Joanmarie Diggs (IRC: joanie) 2010-07-11 07:59:27 UTC
Thanks Steve. Closing as FIXED. I've started looking at more of the keyboard issues tonight. Just solved one problem that may be a partial solution to the Bypass key you mention. Stay tuned!