GNOME Bugzilla – Bug 619171
No visual indication while scanning for folders
Last modified: 2010-06-05 20:58:55 UTC
There is no visual indication when scanning for folders during import. This is especially apparent when selecting a remote location over ssh, it appears as though the import dialog is frozen. In reality it is just walking the filesystem. We need some Icon + Label (and possibly a spinner) somewhere that shows that it's actually doing stuff.
*** Bug 609725 has been marked as a duplicate of this bug. ***
*** Bug 536516 has been marked as a duplicate of this bug. ***
Created attachment 161537 [details] [review] Select selected URI in option menu A first step to indicate that "something" happened when selecting a directory or location. The name of this selection is now selected in the option menu.
Created attachment 161562 [details] [review] Remove unused method
Created attachment 161563 [details] [review] Reload preview pixmap to default if empty collection is found Before the previous preview image was displayed even when selecting a new import source, if this source does not contain images.
Created attachment 161564 [details] [review] Prepare import when selecting previous option menu items Was disabled in 2006, but should work.
Review of attachment 161564 [details] [review]: Rest of the patch looks okay. Still need to test it though. ::: src/ImportCommand.cs @@ +233,3 @@ + public void HandleSourceSelectionChanged (object sender, EventArgs args) + { + SourceItem source = (SourceItem)((SourceMenu)((OptionMenu) sender).Menu).Active; This line scares me to death, please split it up to make it readable.
Attachment 161537 [details] pushed as fd5e26e - Select selected URI in option menu Attachment 161562 [details] pushed as f560c41 - Remove unused method Attachment 161563 [details] pushed as dad45c0 - Reload preview pixmap to default if empty collection is found
Created attachment 161607 [details] [review] Prepare import when selecting previous option menu items https://bugzilla.gnome.org/show_bug.cgi?id=619171 Use correct casts
Comment on attachment 161607 [details] [review] Prepare import when selecting previous option menu items Attachment 161607 [details] pushed as 4a4788c - Prepare import when selecting previous option menu items Added! One last thing: when the import is reset, the iconview should be scrolled all the way up. Should be a one line fix, could you add this? Test this behavior by: * Browse to a folder * Scroll down in the IconView * Browse to another folder * IconView is still showing the middle pictures :-)
Created attachment 161615 [details] [review] scroll to top on changing source
Created attachment 161616 [details] [review] scroll to top on changing source
Created attachment 161618 [details] [review] scroll to top on changing source
Comment on attachment 161618 [details] [review] scroll to top on changing source Attachment 161618 [details] pushed as 5b0c695 - scroll to top on changing source Thanks! Next patch on this bug should actually be a visual indicator of the folder rescan ;-). Open separate patches for other issues.
Do we really need a full folder scan and afterwards the actual import process walking through the loop of found photos again? Can't we just start the import thread and for each item found we do a Prepare () before reading meta information and adding it to the import candidate collection and icon view?
No, may be we shouldn't... This wouldn't help anyway. Disregard this.
The easiest way to do this is probably by changing the progress message in the progress bar to something like "Scanning for photos", making it visible and have it pulsate. The actual scan will need to happen in a different thread or in a way that it doesn't block the main loop.
Pushed a new import system, this is fixed now.