After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 618516 - [typefinding] need raw H.263 typefinder
[typefinding] need raw H.263 typefinder
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.33
Assigned To: parthasarathi susarla
GStreamer Maintainers
: 517916 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-05-13 09:26 UTC by Arun Raghavan
Modified: 2011-02-22 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to add support for raw h.263 (3.06 KB, patch)
2011-02-09 16:31 UTC, parthasarathi susarla 		committed Details | Review

Description Arun Raghavan 2010-05-13 09:26:13 UTC 
We do not currently have a typefinder for raw H.263 streams, likes the one at http://samples.mplayerhq.hu/V-codecs/h263/h263-raw/messenger.h263
Comment 1 Tim-Philipp Müller 2010-11-17 11:29:46 UTC 
*** Bug 517916 has been marked as a duplicate of this bug. ***
Comment 2 parthasarathi susarla 2011-02-09 16:31:21 UTC 
Created attachment 180485 [details] [review]
patch to add support for raw h.263
Comment 3 Tim-Philipp Müller 2011-02-22 11:52:35 UTC 
Pushed, many thanks!

 commit 0ebc34adf94caf2476a18d7188341a903a4b2227
 Author: Parthasarathi Susarla <partha.susarla@collabora.co.uk>
 Date:   Thu Feb 10 03:22:42 2011 +1100

    typefinding: detect raw h.263
    
    https://bugzilla.gnome.org/show_bug.cgi?id=623846

Did some minor changes:

 - used LIKELY + POSSIBLE probabilities, the other ones felt too high

 - removed x263 extension (assuming that's only there for H.264 becasue of the x264 encoder library)

 - added a FIXME for bailing out early in the loop when there are too many bad syncs (ideally we don't want to scan the full 128kB if we are sure it's not h.263)

 - if (good & !bad) => if (good > 0 && bad == 0)