After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623846 - typefinding: add support for "enhanced ac3" (eac3)
typefinding: add support for "enhanced ac3" (eac3)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.29
Other Linux
: Normal normal
: 0.10.31
Assigned To: parthasarathi susarla
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-08 15:20 UTC by parthasarathi susarla
Modified: 2010-07-24 09:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds support for eac3 in gst-typefind (4.78 KB, patch)
2010-07-08 15:20 UTC, parthasarathi susarla 		none Details | Review
adds support for eac3 in gst-typefind - fixes a bug in finding bsid (4.69 KB, patch)
2010-07-11 19:51 UTC, parthasarathi susarla 		none Details | Review
reworked patch against the (latest) git master (4.59 KB, patch)
2010-07-20 06:43 UTC, parthasarathi susarla 		committed Details | Review

Description parthasarathi susarla 2010-07-08 15:20:47 UTC 
Created attachment 165487 [details] [review]
adds support for eac3 in gst-typefind

on an eac3 file ( http://samples.mplayerhq.hu/A-codecs/AC3/eac3/casablanca_aht_mono_64.eac3 ) running gst-typefind does not work:

Current Behaviour:

$ gst-typefind casablanca_aht_mono_64.eac3 
casablanca_aht_mono_64.eac3 - FAILED: Could not determine type of stream.
$

with the patch:

$ gst-typefind casablanca_aht_mono_64.eac3 
casablanca_aht_mono_64.eac3 - audio/x-eac3
$
Comment 1 parthasarathi susarla 2010-07-11 19:51:40 UTC 
Created attachment 165694 [details] [review]
adds support for eac3 in gst-typefind - fixes a bug in finding bsid
Comment 2 parthasarathi susarla 2010-07-20 06:43:28 UTC 
Created attachment 166193 [details] [review]
reworked patch against the (latest) git master
Comment 3 Tim-Philipp Müller 2010-07-24 09:03:12 UTC 
Pushed, thanks for the patch:

commit aad661ec776b9be8e27723d09795622cc56710e0
Author: Parthasarathi Susarla <partha.susarla@collabora.co.uk>
Date:   Tue Jul 20 12:08:52 2010 +0530

    typefinding: detect enhanced AC-3
    
    https://bugzilla.gnome.org/show_bug.cgi?id=623846