GNOME Bugzilla – Bug 614795
Icon for tomboy in notification area is different from icon for tomboy applet
Last modified: 2010-06-06 16:52:25 UTC
Created attachment 157856 [details] screenshot showing icon difference between applet and notification area icon I havent filed this as an "enhancement" , since , this was supposed to have been fixed in bug 612887 As mentioned by Sandy Armstrong , here > https://bugs.launchpad.net/ubuntu/+source/tomboy/+bug/552292/comments/4 and somehow the patch isnt working. Steps to reproduce: 1: Launch tomboy from Applications> Accessories > Tomboy Notice , that tomboy when using the notification area , it use the monochrome "tomboy-panel" icon [present in both Humanity and Ubuntu-mono] 2: Add Tomboy applet via "Add to panel" Deviation: Now notice that the applet uses only the color icon "tomboy" Expected: The icon used by the applet should also be a monochrome icon as used by the notification area icon.
Created attachment 161298 [details] [review] Use "tomboy-panel" icon in panel applet Here is a patch against Applet.cs from Tomboy 1.2.1 that fixes the issue.
Sorry if this is slightly OT, but I'd like to try out your patch, Brian - unfortunately, http://projects.gnome.org/tomboy/download.html offers only the 1.2.0 sources for download - where can I get the 1.2.1 sources?
It looks like the Applet.cs file hasn't changed since this issue was half fixed in commit 3421c5a8f... So, Raphael, you can apply the patch to 1.2.0 if you'd like. If you'd like a newer version, I got 1.2.1 from git://git.gnome.org/tomboy
Hi Brian, thanks for the Git URL! I was interested in the Sketching function anyways so I just got HEAD. Your patch applied nonetheless and is working perfectly. Thanks for it!
Comment on attachment 161298 [details] [review] Use "tomboy-panel" icon in panel applet Brian, your patch looks good. Although this proves that we are loading the icon twice, and the first load is probably totally unnecessary. Do you have commit access?
I don't have commit access, but wouldn't be opposed. The first icon load (in TomboyPanelAppletEventBox()) loads a size 16 icon, with a comment "to ensure we don't end up with a 1x1 panel". Then when the widget is actually allocated, the current panel size is used to load a correctly sized icon. So, they may both be necessary, although the actual icon loaded at first is irrelevant since it gets replaced by the one in InitPixbuf().