After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612887 - Tomboy uses the same icon for the panel and the menu
Tomboy uses the same icon for the panel and the menu
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
1.0.x
Other Linux
: Normal minor
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-14 16:55 UTC by Jason
Modified: 2010-05-21 05:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allows icon themes to customize the Tomboy panel icon (832 bytes, patch)
2010-03-14 18:41 UTC, Jason 		none Details | Review

Description Jason 2010-03-14 16:55:12 UTC 
Tomboy uses the same icon [icon name: "tomboy" ] for the panel and the menu.

In order to create an icon theme that can customize the panel icon without modifying the Tomboy Application icon it it will need to use a separate icon name for the panel (Preferably an icon named "tomboy-panel").

This bug was originally reported by user Mike Basinger in Ubuntu's bug tracker.
Link: https://bugs.launchpad.net/tomboy/+bug/531533

I'm willing to fix this and submit a patch. I would like to know if the Gnome Project will be willing to accept such a patch.  Thanks.
Comment 1 Jason 2010-03-14 18:41:12 UTC 
Created attachment 156132 [details] [review]
Allows icon themes to customize the Tomboy panel icon

I've created a patch against Tomboy/Tray.cs that first attempts to load the "tomboy-panel" icon. If that icon does not exist then it attempts to load to original "tomboy" icon.

This will allow icon themes to customize the panel icon used for Tomboy.
Comment 2 Sandy Armstrong 2010-03-15 14:35:27 UTC 
This looks good. Today is hard code freeze so I will either push it today or it will get delayed to next cycle.

Thanks for the patch!
Comment 3 Sandy Armstrong 2010-03-15 15:02:16 UTC 
I pushed a patch based on yours to master; this will be in 1.2.0.
Comment 4 Brian Mattern 2010-05-21 05:20:52 UTC 
This was only partially fixed in Applet.cs, there are two locations in that file which load the icon. I have attached a patch at bug 614795 regarding this.