After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614637 - Bad interaction between EOG and its Fspot editor
Bad interaction between EOG and its Fspot editor
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.30.x
Other Linux
: Normal major
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-02 02:55 UTC by Yann
Modified: 2010-12-11 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Yann 2010-04-02 02:55:21 UTC
Bug first reported on Launchpad https://bugs.launchpad.net/ubuntu/+source/eog/+bug/548880

As you know on Lucid, there is an "Edit image" button inside EOG. When clicking on it, it opens the Fspot editor without closing the EOG window. I think this will lead to misunderstanding from the user:

- Open an image with EOG. Then modify it with the "Edit image" button located inside EOG. Modify it, save the changes. The image in EOG is not updated.
--> Here the user is clearly expecting the EOG image to be updated, as he does not know/care that EOG is using an external editing app. It is affecting Ubuntu's ergonomy, so I really think it should be changed ("wishlist" with high priority ? Ubuntu's bug ?).

I though there could be a solution that could be easily put it place:
1) When clicking the "Edit image" button, the EOG should be automatically closed.
2) When closing the Fspot editor, this should automatically re-open the EOG window (that would of course be updated).
Comment 1 Claudio Saavedra 2010-04-02 13:42:57 UTC
(In reply to comment #0)
> Bug first reported on Launchpad
> https://bugs.launchpad.net/ubuntu/+source/eog/+bug/548880
> 
> As you know on Lucid, there is an "Edit image" button inside EOG.

I am tempted to say "why should I know?" but I guess you mean the patch by Ryan in bug 609958.

> 
> - Open an image with EOG. Then modify it with the "Edit image" button located
> inside EOG. Modify it, save the changes. The image in EOG is not updated.
> --> Here the user is clearly expecting the EOG image to be updated, as he does
> not know/care that EOG is using an external editing app. It is affecting
> Ubuntu's ergonomy, so I really think it should be changed ("wishlist" with high
> priority ? Ubuntu's bug ?).

With all due respect, I don't care much about Ubuntu's ergonomy's but GNOME one. GNOME doesn't have that patch currently in the Eye of GNOME, so I think that it would be nice if this issue is addressed first by the Ubuntu downstream developers.

Now, to the topic. eog could perfectly fine reload the image when any external change to it happen. But then, there could be unsaved changes in eog itself, like a rotation of the image. In such cases I don't think it would be a good idea to reload the image.

> 
> I though there could be a solution that could be easily put it place:
> 1) When clicking the "Edit image" button, the EOG should be automatically
> closed.
> 2) When closing the Fspot editor, this should automatically re-open the EOG
> window (that would of course be updated).

This could be easily put in place but it's not nice at all and it doesn't solve the underlying issue.
Comment 2 Yann 2010-04-03 13:15:44 UTC
Thank you for your answer. (Sorry I was not sure if the "Edit image" button was a patch added by Ubuntu, or not.) 

> eog could perfectly fine reload the image when any external
> change to it happen. But then, there could be unsaved changes in eog itself,
> like a rotation of the image. In such cases I don't think it would be a good
> idea to reload the image.

I agree an automatic reload may cause problems. I prefer the idea of Fabricio in Bug 534348 (EOG suggests to reload a modified file, in a simple way like Gedit does)
Comment 3 Felix Riemann 2010-10-06 18:50:37 UTC
Bug 534348 has been resolved. So, is this resolved as well (assuming Ubuntu has patched 2.32 as well)?
Comment 4 Felix Riemann 2010-12-11 13:48:09 UTC
As nobody is complaining, I'm closing this then.