After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534348 - eog should suggest to reload a modified file
eog should suggest to reload a modified file
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.22.x
Other All
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 614635 (view as bug list)
Depends on:
Blocks: 614634
 
 
Reported: 2008-05-22 13:44 UTC by Fabricio Silva
Modified: 2010-09-14 12:22 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Add a EogImage::file-changed signal (2.56 KB, patch)
2010-09-10 14:55 UTC, Claudio Saavedra
none Details | Review
Emit ::file-changed when a image in a a monitored directory changes (1.14 KB, patch)
2010-09-10 14:55 UTC, Claudio Saavedra
none Details | Review
Ask the user whether to reload an externally modified image (4.06 KB, patch)
2010-09-10 14:55 UTC, Claudio Saavedra
none Details | Review

Description Fabricio Silva 2008-05-22 13:44:19 UTC
Like Gedit for text files, EOG could suggest to reload a modified file or to keep the previously loaded image when getting focus.
When a file is modified, even when if new file item is clicked in nautilus, eog still shows the old file.
Comment 1 Sam Morris 2009-07-28 11:45:58 UTC
Related to #555370
Comment 2 Claudio Saavedra 2010-04-02 13:45:13 UTC
*** Bug 614635 has been marked as a duplicate of this bug. ***
Comment 3 Yann 2010-04-03 09:29:50 UTC
I agree with Fabricio's suggestion. A simple message like in Gedit would be sufficient to avoid confusion.

This becomes important now, especially with the "Edit image" button in Ubuntu 10.04 LTS, see https://bugs.launchpad.net/ubuntu/+source/eog/+bug/548880
Comment 4 Yann 2010-09-08 14:57:23 UTC
Any news for this bug ?

it will be very visible in Ubuntu 10.10 .

(by the way I updated the Ubuntu bug descriptions, the correct downstream report is now : https://bugs.launchpad.net/eog/+bug/632810 )
Comment 5 Claudio Saavedra 2010-09-08 16:47:59 UTC
It will be as visible as in any other distro. Please don't poke in vain.
Comment 6 Yann 2010-09-09 01:32:01 UTC
This bug (indeed #614635) is highly visible when there is an "Edit Image" button in EOG. I know this button is in Ubuntu 10.04 and 10.10, I don't know for other distro.

According to #609958, the "Edit Image" button is not implemented yet in the Gnome EOG, that is why I suppose not all distro have it, and that is why I pointed out the specificity of Ubuntu.

Sorry for the bugzilla spam.
Comment 7 Claudio Saavedra 2010-09-10 14:55:17 UTC
Created attachment 169955 [details] [review]
Add a EogImage::file-changed signal

This is going to be useful to broadcast changes in the underlying file
Comment 8 Claudio Saavedra 2010-09-10 14:55:25 UTC
Created attachment 169956 [details] [review]
Emit ::file-changed when a image in a a monitored directory changes
Comment 9 Claudio Saavedra 2010-09-10 14:55:31 UTC
Created attachment 169957 [details] [review]
Ask the user whether to reload an externally modified image

Fixes bug 534348 - eog should suggest to reload a modified file
Comment 10 Claudio Saavedra 2010-09-14 12:22:33 UTC
Pushed these patches (last one being a bit more refined) to master and gnome-2-32.