GNOME Bugzilla – Bug 614634
EOG prevents the Desktop thumbnails to be updated.
Last modified: 2010-10-07 05:16:45 UTC
(bug first reported on Launchpad: https://bugs.launchpad.net/ubuntu/+source/eog/+bug/548880) On Ubuntu 10.04 - Copy an image on your Desktop (this step is important) - Open it with EOG. Then modify it with the "Edit image" button located inside EOG. Modify it, save the changes. The on the Desktop is not updated (the thumbnail disappears as if was being updated, but then returns the same as before). - Close the EOG window (without closing the Fspot window), then save again the modification in Fspot. This time the thumbnail on the Desktop is updated. --> It looks that EOG prevents the thumbnail to be updated.
(In reply to comment #0) > (bug first reported on Launchpad: > https://bugs.launchpad.net/ubuntu/+source/eog/+bug/548880) > > On Ubuntu 10.04 > > - Copy an image on your Desktop (this step is important) > - Open it with EOG. Then modify it with the "Edit image" button located inside > EOG. Modify it, save the changes. The on the Desktop is not updated (the > thumbnail disappears as if was being updated, but then returns the same as > before). This step is not reproducible with upstream Eye of GNOME. > - Close the EOG window (without closing the Fspot window), then save again the > modification in Fspot. This time the thumbnail on the Desktop is updated. > --> It looks that EOG prevents the thumbnail to be updated. I'll close this as invalid. If you can provide different steps to reproduce this bug that doesn't require the downstream modifications, then please reopen.
Thank you for your answer. So this bug is specific to the Ubuntu's version of EOG only ? That means it must be discussed on Launchpad, and solved by the Ubuntu's team, am I right ? Regards
(In reply to comment #2) > Thank you for your answer. > > So this bug is specific to the Ubuntu's version of EOG only ? > That means it must be discussed on Launchpad, and solved by the Ubuntu's team, > am I right ? As long as the way you describe above is the only way to reproduce the problem and the Ubunutu team deems it critical enough, this is correct. But, if you can find a way to reproduce it without requiring (yet-)Ubuntu-specific features we can investigate the problem.
Okay, just played around a bit out of curiosity how eog could block thumbnailing and I think I might have found an alternative way to reproduce it: 1. Copy the image to the Desktop (it's reproducible in other folders too, but harder to catch) 2. Open the image in eog. 3. Select File->Open with->[Pick any editor] (I used GIMP) 4. Modify the image in the editor and save it. This shows the wrong thumb here. Yann, can you confirm that this is the same problem?
I was writing the same at the same time ;) I could reproduce using Gimp, and Fspot (opened separately, not from the EOG button). Another remark: after your procedure, close EOG and Gimp, then open the image again (from the Desktop) with EOG : the thumbnail is not updated. Close EOG. Then open Nautilus and go to the Desktop folder, open the image with EOG from Nautilus, this time the thumbnail is updated !
Okay, this is related to the codepath in eog that creates thumbnails from the currently loaded pixbuf. eog apparently gets notified that the image has changed and goes to update the thumbnail. As it is currently loaded it takes the fast path to use the currently loaded pixbuf data to generate the thumbnail without respecting the image data has changed. If you modify an image that is currently not the active image in eog it works correctly. I'm not so much into eog's thumbnailing code anymore, so don't expect a quick fix. (Hmm, apparently it's not possible to go from VERIFIED to NEW directly.)
Setting milestone as this is going to be a rather visible bug once the patch from bug 609958 is merged (not setting it as a blocker for it yet). Sorry for the bugzilla spam.
I can look into this.
Any news for this bug ? (by the way I updated the Ubuntu bug descriptions, the correct downstream report is now : https://bugs.launchpad.net/eog/+bug/633228 )
This is not the only problem. Also, if nautilus is quick enough, eog will just load the thumbnail from the cache (which will be updated to reflect the file changes) and will put it, for instance, in the application icon, making it inconsistent with the shown image.
Created attachment 169944 [details] [review] Store in EogImage the modification time of the file
Created attachment 169945 [details] [review] Add eog_image_get_modification_time() accessor
Created attachment 169946 [details] [review] Do not use the loaded pixbuf to update the thumbnail when outdated Fixes bug 614634 - EOG prevents the Desktop thumbnails to be updated
Is there a reason this is done using the mtime? Couldn't this use the work from bug 534348? Just notice the file changed and mark the image data as outdated until it's reloaded?
Created attachment 170167 [details] [review] Store the changed status of an image file
Created attachment 170168 [details] [review] Add eog_image_is_file_changed()
Created attachment 170169 [details] [review] Don't create thumbnails out of outdated image pixbufs Fixes bug #614634 - EOG prevents the Desktop thumbnails to be updated
OK, you are correct. I fixed it this other way because I had no plans to work on bug 534348. But once we get these patches in, this is a sensible way to do it, indeed. I am not yet 100% convinced about the new function name, it's a bit odd to me.
(In reply to comment #18) > I am not yet 100% convinced about the new function name, it's a bit odd to me. Hmm, what about eog_image_needs_reload() or eog_image_is_in_sync() (or just synced?)?
Hm, apparently you put this bug in the NEWS file instead of 534348 ?
(In reply to comment #20) > Hm, apparently you put this bug in the NEWS file instead of 534348 ? Whoops! This is the stuff that happens when I open too many tabs in Firefox. :) Fixed it!
Pushed to master to have it fixed. We can still rename the function in the next months if we find a better name. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Thank you Felix and Claudio for having solved it !