After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614592 - 2.30.0 dies on right clicking titlebar
2.30.0 dies on right clicking titlebar
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.30.x
Other Linux
: Normal critical
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
: 614642 614830 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-01 15:12 UTC by Edward Sheldrake
Modified: 2010-04-06 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (396 bytes, patch)
2010-04-01 15:12 UTC, Edward Sheldrake
committed Details | Review

Description Edward Sheldrake 2010-04-01 15:12:32 UTC
Created attachment 157702 [details] [review]
fix

metacity 2.30.0 quits and gets re-started when I right-click any titlebar.

from .xsession-errors

**
metacity:ERROR:core/prefs.c:2759:meta_prefs_get_window_binding: code should not be reached

I added a debugging line, it seems meta_prefs_get_window_binding() is being called with name "none", triggering an assertion. I fixed it by not bothering to look up the menu accelerator for META_MENU_OP_NONE.
Comment 1 Saleem Abdulrasool 2010-04-02 03:45:46 UTC
This seems to be a regression caused by 333446ab5f6b773b4c8357a302d80155e8851d22.
Comment 2 Frederic Crozat 2010-04-02 12:09:59 UTC
*** Bug 614642 has been marked as a duplicate of this bug. ***
Comment 3 Frederic Crozat 2010-04-02 12:10:48 UTC
confirming ( https://qa.mandriva.com/show_bug.cgi?id=58520 ) :


Program received signal SIGABRT, Aborted.
0xffffe424 in __kernel_vsyscall ()
(gdb) bt
  • #0 __kernel_vsyscall
  • #1 raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
  • #2 abort
    at abort.c line 92
  • #3 IA__g_assertion_message
    at gtestutils.c line 1318
  • #4 g_io_channel_unref
    at giochannel.c line 246
  • #5 g_io_channel_unref
    at giochannel.c line 246
  • #6 g_io_channel_unref
    at giochannel.c line 246
  • #7 g_io_channel_unref
    at giochannel.c line 246
  • #8 g_io_channel_unref
    at giochannel.c line 246
  • #9 g_io_channel_unref
    at giochannel.c line 246
  • #10 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #11 g_type_class_meta_marshal
    at gclosure.c line 878
  • #12 IA__g_closure_invoke
    at gclosure.c line 767
  • #13 signal_emit_unlocked_R
    at gsignal.c line 3286
  • #14 IA__g_signal_emit_valist
    at gsignal.c line 2991
  • #15 IA__g_signal_emit
    at gsignal.c line 3038
  • #16 gtk_widget_event_internal
    at gtkwidget.c line 4943
  • #17 IA__gtk_propagate_event
    at gtkmain.c line 2442
  • #18 IA__gtk_main_do_event
    at gtkmain.c line 1608
  • #19 gdk_event_dispatch
    at gdkevents-x11.c line 2372
  • #20 g_main_dispatch
    at gmain.c line 1960
  • #21 IA__g_main_context_dispatch
    at gmain.c line 2513
  • #22 g_main_context_iterate
    at gmain.c line 2591
  • #23 IA__g_main_loop_run
    at gmain.c line 2799
  • #24 g_io_channel_unref
    at giochannel.c line 246
  • #25 __libc_start_main
    at libc-start.c line 226
  • #26 g_io_channel_unref
    at giochannel.c line 246

Comment 4 Jasper St. Pierre (not reading bugmail) 2010-04-05 17:30:09 UTC
*** Bug 614830 has been marked as a duplicate of this bug. ***
Comment 5 Frederic Crozat 2010-04-06 09:41:21 UTC
I confirm patch fixes the crash.
Comment 6 Vincent Untz 2010-04-06 10:06:24 UTC
Thanks, pushed and I'll do a release.