GNOME Bugzilla – Bug 614319
Search bar shouldn't resize the chat window
Last modified: 2011-04-07 09:39:13 UTC
Two problems: 1. Find bar is not friendly with the minimalist window width (as narrow as the menubar allows), so it resizes it everytime you activate it. 2. Resized window is not resized back to its original width after using the find bar. IMO either make the find bar friendlier to narrow windows or make it restore the original width after being closed.
Actually I'd prefer if the search bar wouldn't resize the Window as the Epiphany one.
This issue is a duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=611855
*** Bug 611855 has been marked as a duplicate of this bug. ***
Fixed in repo: git://vminko.org/empathy branch: fix-614319
Created attachment 173914 [details] [review] proposed fix
Review of attachment 173914 [details] [review]: Is that the way it's done in Epiphany? I tried but it didn't work here, the search bar doesn't appear :\
>Is that the way it's done in Epiphany? Yes. >I tried but it didn't work here, the search bar doesn't appear :\ I think this issue is not caused by my changes, because I observe the same behavior using the original search bar code. I filed a separate issue for this problem: https://bugzilla.gnome.org/show_bug.cgi?id=634688
Ok, let's fix bug #634688 first then.
This issue is no longer reproducible. However, the fix is implemented in a different way (Empathy just truncates the search bar, there is no dropdown menu with hidden button). So please let me know your opinion. If you are OK with the current solution - then I think the bug should be closed. If you prefer my approach - I'll update the patch.
Yeah I think it would be cool to have the dropdown menu.
Well actually there is nothing to update. The original patch works fine for me with empathy-3.0.0.
Created attachment 185177 [details] screenshot I tested your branch and the bar is pretty big here.
Created attachment 185185 [details] another screenshot Try this branch: fix-614319-v2 It looks quite nice IMHO.
Author: vminko <vminko@vminko-virtual-machine.(none)> Time to "git config" :) Humm I still have the same big button, are you sure you pushed the right patch? (942ddf97dbc275dbfd7df76560a2c3ad5730c1ee)
>Time to "git config" :) Ouch, thanks for letting me know. >Humm I still have the same big button, are you sure you pushed the right patch? I pushed the right patch and I can't reproduce this behavior, but I guess that the extra height is caused by the Find Prev/Next buttons, because the icons are displayed on top of the labels. So this time I explicitly specified the correct style: GTK_TOOLBAR_BOTH_HORIZ. Please try the new branch: fix-614319-v3
I just branched for 3.0, you'll be please to know that your branch is the first 3.2 feature. :) Merged to master, thanks a lot. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.