GNOME Bugzilla – Bug 634688
Search bar is not visible
Last modified: 2011-08-29 10:12:43 UTC
Steps to reproduce: 1. Run empathy 2. Start conversation 3. Press Ctrl-F Expected result: Search bar appears. Actual result: Search bar is almost invisible. Notes: Not reproducible with empathy-2.32, probably related to GTK3.
I can reproduce it as well.
Fixed in repo: git://vminko.org/empathy branch: fix-634688
size_request is the old school way to do that. You should use get_preferred_{height,width) or get_preferred_width_for_height/get_preferred_height_for_width depending on the mode set on the widget.
Fixed in fix-634688-v2
Created attachment 174529 [details] [review] updated patch
Review of attachment 174529 [details] [review]: ::: libempathy-gtk/empathy-search-bar.c @@ +309,2 @@ /* Neither GtkBin nor GtkContainer seems to do this for us :( */ + widget_class->size_request = empathy_search_bar_size_request; Nope, I mean you should define get_preferred_{width,height} instead of size_request.
Fixed in fix-634688-v3 Actually get_preferred_width is unnecessary.
Created attachment 174594 [details] [review] updated updated patch
Coolio; I merged it to master. Thanks ! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.