After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634688 - Search bar is not visible
Search bar is not visible
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-12 15:54 UTC by Vitaly Minko
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
updated patch (1.33 KB, patch)
2010-11-15 17:31 UTC, Vitaly Minko
reviewed Details | Review
updated updated patch (1.30 KB, patch)
2010-11-16 11:15 UTC, Vitaly Minko
none Details | Review

Description Vitaly Minko 2010-11-12 15:54:26 UTC
Steps to reproduce:
1. Run empathy
2. Start conversation
3. Press Ctrl-F

Expected result:
Search bar appears.

Actual result:
Search bar is almost invisible.

Notes:
Not reproducible with empathy-2.32, probably related to GTK3.
Comment 1 Guillaume Desmottes 2010-11-15 09:06:10 UTC
I can reproduce it as well.
Comment 2 Vitaly Minko 2010-11-15 15:07:32 UTC
Fixed in
repo: git://vminko.org/empathy
branch: fix-634688
Comment 3 Guillaume Desmottes 2010-11-15 15:41:16 UTC
size_request is the old school way to do that. You should use get_preferred_{height,width) or get_preferred_width_for_height/get_preferred_height_for_width depending on the mode set on the widget.
Comment 4 Vitaly Minko 2010-11-15 17:30:36 UTC
Fixed in fix-634688-v2
Comment 5 Vitaly Minko 2010-11-15 17:31:32 UTC
Created attachment 174529 [details] [review]
updated patch
Comment 6 Guillaume Desmottes 2010-11-16 09:03:29 UTC
Review of attachment 174529 [details] [review]:

::: libempathy-gtk/empathy-search-bar.c
@@ +309,2 @@
   /* Neither GtkBin nor GtkContainer seems to do this for us :( */
+  widget_class->size_request = empathy_search_bar_size_request;

Nope, I mean you should define get_preferred_{width,height} instead of size_request.
Comment 7 Vitaly Minko 2010-11-16 11:15:05 UTC
Fixed in fix-634688-v3
Actually get_preferred_width is unnecessary.
Comment 8 Vitaly Minko 2010-11-16 11:15:28 UTC
Created attachment 174594 [details] [review]
updated updated patch
Comment 9 Guillaume Desmottes 2010-11-16 13:12:46 UTC
Coolio; I merged it to master. Thanks !

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.