After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613923 - gfile.c: splice_stream_with_progress: wrong error handling
gfile.c: splice_stream_with_progress: wrong error handling
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.23.x
Other Linux
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-03-25 15:26 UTC by Dmitry Bashkatov
Modified: 2010-03-26 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix splice_stream_with_progress error handling (387 bytes, text/plain)
2010-03-25 15:26 UTC, Dmitry Bashkatov 		Details

Description Dmitry Bashkatov 2010-03-25 15:26:37 UTC 
Created attachment 157075 [details]
fix splice_stream_with_progress error handling

I was investigating nautilus bug https://bugzilla.gnome.org/show_bug.cgi?id=342437 and found that glib function in gio/gfile.c splice_stream_with_progress has wrong error handling. In some cases function returns TRUE, while *error != NULL.

Little patch will fix it.
Comment 1 Christian Kellner 2010-03-26 13:41:41 UTC 
Fixed by Matthias with commit 6e77ee0.

Good catch thanks!