GNOME Bugzilla – Bug 613082
Allow a user to start a new instance of a application using only the keyboard
Last modified: 2011-07-16 20:53:38 UTC
Current behavior : - Press the Super key - Type the name of an application already running in the find "box" - Need to Ctrl-Click on the application icon to launch a new instance Desired behavior : - Press the Super key - Type the name of an application already running in the find "box" - Press Ctrl-Enter and the new instance of the application is launched. It seems to me rather logic since we can already launch a new instance of an application by Ctrl-Clicking on the icon, so Ctrl-Enter seems natural
I concur. The more I can do with only keyboard, the happier I am.
Created attachment 184368 [details] [review] Ctrl-Enter inside search opens new window
In addition to a key-combo to launch a new window, it would also be useful to have one to launch an app in a new workspace, duplicating the middle-click behavior.
*** Bug 647212 has been marked as a duplicate of this bug. ***
Makes a lot of sense to have this to me, it follows the dash logic and add a quick way to launch a new window with just the keyboard.
*** Bug 652608 has been marked as a duplicate of this bug. ***
Review of attachment 184368 [details] [review]: ::: js/ui/viewSelector.js @@ +145,2 @@ this._text.connect('text-changed', Lang.bind(this, this._onTextChanged)); + this._text.connect('activate', Lang.bind(this, this._onActivate)); It is better to manually handle this in _onKeyPress. @@ +278,3 @@ + + if (!this.active) + return true; It should return TRUE only if the event has been handled.
*** Bug 654424 has been marked as a duplicate of this bug. ***
Ron, are you going to continue working on this?
I'm sorry that I didn't reported back earlier after the review, but I had trouble building GNOME Shell and forgot about it. Because I still have trouble building it, I would suggest to take Maxim Ermilovs patch from Bug 652608. After the review my patch would be basically the same anyway. The only notable difference is that his patch doesn't check the app.state inside appDisplay.js.
Quote: "Current behavior : - Press the Super key - Type the name of an application already running in the find "box" - Need to Ctrl-Click on the application icon to launch a new instance Desired behavior : - Press the Super key - Type the name of an application already running in the find "box" - Press Ctrl-Enter and the new instance of the application is launched. " End Quoute: Just a note, the desired behavior is already a feature in Windows 7. Superkey+Type+When Satisfied with the result,just press enter. This is a nice feature.
*** Bug 648910 has been marked as a duplicate of this bug. ***
Created attachment 192093 [details] [review] viewSelector: Bind <Ctrl>+<Return> for open new window
Review of attachment 192093 [details] [review]: ::: js/ui/viewSelector.js @@ +143,3 @@ this._text.connect('text-changed', Lang.bind(this, this._onTextChanged)); + this._text.connect('key-press-event', Lang.bind(this, function (o, e) { + // ClutterText::activate signal is not emitted on <Ctrl>+<Return> This comment doesn't really make sense without the context of this bug. Try: // We can't connect to 'activate' here because search providers // might want to do something with the modifiers in activateSelected.
Created attachment 192097 [details] [review] viewSelector: Bind <Ctrl>+<Return> for open new window
Review of attachment 192097 [details] [review]: LGTM.