After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612931 - Moving individual layer in layer group not possible with Move Tool in 'pick a layer' mode
Moving individual layer in layer group not possible with Move Tool in 'pick a...
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal minor
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
: 639307 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-03-15 12:19 UTC by gemy cedric
Modified: 2011-08-20 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow moving individual layers in a layer group (1.03 KB, patch)
2010-07-10 00:56 UTC, Gilles Rochefort
rejected Details | Review
0001-Bug-612931-Moving-individual-layer-in-layer-group-no.patch (3.80 KB, patch)
2011-08-20 13:04 UTC, Martin Nordholts
committed Details | Review

Description gemy cedric 2010-03-15 12:19:06 UTC
Assume you've a layer group with several layer inside. With any tool, acting on one layer will modify only this one. But with the move tool, all the grouped layers are affected. This is not consistent. Linking layers or multiselection in layer window should be preferred.
Comment 1 Michael Natterer 2010-03-15 17:50:16 UTC
Layer group handling is simply unfinished.
Comment 2 Gilles Rochefort 2010-07-10 00:56:03 UTC
Created attachment 165595 [details] [review]
Allow moving individual layers in a layer group
Comment 3 gemy cedric 2010-07-10 22:09:13 UTC
lo Gilles
It sounds good and i applied it. It builds well but it seems that the behavior stills the same. In fact it behave well if the "move current layer" only is checked but not if the first "pick a layer" (fr:"pointer un calque actif").
Comment 4 Gilles Rochefort 2010-07-11 10:30:37 UTC
Hi Cedric,

That very little patch only intends to fix a minor problem with the option "pick a layer", it doesn't change anything else.

If the "move current layer" is selected, you can move the whole group or any single layer inside the group (by selecting it of course)

If the option "pick a layer" is activated, when you try to pick a layer inside a layer group it fails; you can only move the whole group not a single layer inside the group.

I tried the following experiment :
1/ create a new image
2/ create a group and put the new image inside
3/ create a new layer (I use transparent layer)
4/ Draws something on each layer
5/ enable the "pick a layer" option, and try to move each layer of the group by clicking on part of the image. 

So, you can't move only one single layer, it always moves the whole group of layers.
Comment 5 Martin Nordholts 2010-09-16 19:01:53 UTC
Review of attachment 165595 [details] [review]:

Sounds as if the patch needs-work
Comment 6 Michael Natterer 2011-02-14 11:05:49 UTC
*** Bug 639307 has been marked as a duplicate of this bug. ***
Comment 7 Martin Nordholts 2011-08-20 13:04:20 UTC
Created attachment 194287 [details] [review]
0001-Bug-612931-Moving-individual-layer-in-layer-group-no.patch

This is really Gilles patch but the "proper" solution, and it seems to work fine.
Comment 8 Michael Natterer 2011-08-20 13:31:46 UTC
Comment on attachment 194287 [details] [review]
0001-Bug-612931-Moving-individual-layer-in-layer-group-no.patch

Looks perfect to me.
Comment 9 Martin Nordholts 2011-08-20 15:59:33 UTC
commit 80beaa6b5a78feca3f8173f27a838120f25eca0f
Author: Martin Nordholts <martinn@src.gnome.org>
Date:   Sat Aug 20 15:01:46 2011 +0200

    Bug 612931 - Moving individual layer in layer group not possible with Move Tool in 'pick a layer' mode
    
    When using GimpPickable::get_opacity_at(), don't consider group layers
    as having content.
Comment 10 Martin Nordholts 2011-08-20 16:00:12 UTC
Review of attachment 165595 [details] [review]:

Rejected since another fix was pushed. Thanks for the patch anyway.
Comment 11 Martin Nordholts 2011-08-20 16:11:56 UTC
Review of attachment 194287 [details] [review]:

commited