After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612631 - banshee 1.5.5 crashes on startup
banshee 1.5.5 crashes on startup
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.5.5
Other Linux
: Normal critical
: 1.6
Assigned To: Banshee Maintainers
Banshee Maintainers
: 612817 613290 613425 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-03-11 20:34 UTC by cruejones
Modified: 2010-03-20 19:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
output from terminal on banshee start (5.13 KB, text/plain)
2010-03-11 20:34 UTC, cruejones
  Details
debug patch (1.23 KB, patch)
2010-03-12 05:27 UTC, Gabriel Burt
none Details | Review
'make run' output (10.77 KB, text/plain)
2010-03-12 14:37 UTC, Tim Elkins
  Details
Cool, thanks Tim (and thanks for fixing up my patch). Here's another one w/ some more output. Also, it should print a warning to the terminal instead of crashing. Can you apply/make run it? (2.33 KB, patch)
2010-03-12 19:51 UTC, Gabriel Burt
none Details | Review
'make run' output (10.87 KB, text/plain)
2010-03-12 20:53 UTC, Tim Elkins
  Details
Banshee crash log output (7.31 KB, application/x-bzip)
2010-03-14 17:21 UTC, Philip Gillißen
  Details
patch (4.00 KB, patch)
2010-03-16 22:53 UTC, Gabriel Burt
none Details | Review
Debug after applying patch (10.66 KB, application/octet-stream)
2010-03-16 23:20 UTC, Michael Gorelick
  Details

Description cruejones 2010-03-11 20:34:55 UTC
Created attachment 155891 [details]
output from terminal on banshee start

banshee 1.5.5 crashes on startup.  startup terminal output attached.

Base OS/Distro: SLED-11-x86_64 (fully patched)

Mono: mono-core-2.0.1-1.19.1

Banshee:
~> rpm -qa banshee\*
banshee-1-backend-engine-gstreamer-1.5.5-1.1
banshee-1-extensions-default-1.5.5-1.1
banshee-1-client-classic-1.5.5-1.1
banshee-1-backend-platform-gnome-1.5.5-1.1
banshee-1-dmp-ipod-1.5.5-1.1
banshee-1-novell-aac-0.10.6-1.29
banshee-1-core-1.5.5-1.1
banshee-1-1.5.5-1.1
banshee-1-backend-platform-unix-1.5.5-1.1
banshee-1-lang-1.5.5-1.1
banshee-1-devel-1.5.5-1.1
banshee-1-dmp-1.5.5-1.1
banshee-1-dmp-mtp-1.5.5-1.1
Comment 1 Tim Elkins 2010-03-11 22:39:37 UTC
Banshee is also crashing for me on startup with the same terminal output as above.

Distro: Ubuntu 9.04 (32-bit, fully patched)
Mono: mono 2.0.1-4ubuntu0.1

Banshee:
banshee 1.5.5-1~hyper1~jaunty
podsleuth 0.6.4-1
Comment 2 Gabriel Burt 2010-03-12 00:12:52 UTC
Cool, thanks for the reports guys, we'll try to get it fixed ASAP.
Comment 3 Thomas Sibley 2010-03-12 04:04:07 UTC
I'm in the same situation as Tim Elkins above.  Sigh.
Comment 4 Gabriel Burt 2010-03-12 04:12:02 UTC
Are any of you able to build/run Banshee from git master?  http://banshee-project.org/download/development/ explains how.  If so, please do, and confirm that you still have the crash, then I'll work on a fix
Comment 5 Thomas Sibley 2010-03-12 04:28:33 UTC
I could, but I'm in automake hell right now and getting this from configure:

./configure: line 12032: SHAMROCK_EXPAND_LIBDIR: command not found
./configure: line 12033: SHAMROCK_EXPAND_BINDIR: command not found
./configure: line 12034: SHAMROCK_EXPAND_DATADIR: command not found
./configure: line 12036: BANSHEE_CHECK_LIBBANSHEE: command not found
./configure: line 12037: BANSHEE_CHECK_GSTREAMER: command not found
./configure: line 12039: BANSHEE_CHECK_NOW_PLAYING_X11: command not found
./configure: line 12041: syntax error near unexpected token `1.9.1'
./configure: line 12041: `SHAMROCK_CHECK_MONO_MODULE(1.9.1)'

Can someone tell me what autotool incantation I should be using to build a proper configure?
Comment 6 Thomas Sibley 2010-03-12 04:37:32 UTC
Nevermind, I didn't see autogen.sh at first.
Comment 7 Tim Elkins 2010-03-12 05:14:27 UTC
(In reply to comment #4)
> Are any of you able to build/run Banshee from git master? 
> http://banshee-project.org/download/development/ explains how.  If so, please
> do, and confirm that you still have the crash, then I'll work on a fix

Still crashing after built from git master, same error output as before except for the version number: "Running Banshee 1.5.5: [git-checkout (linux-gnu, i686) @ 2010-03-11 23:57:14 EST]"

BTW, I compiled it with --disable-youtube because I didn't have google-gdata installed.
Comment 8 Gabriel Burt 2010-03-12 05:27:42 UTC
Created attachment 155927 [details] [review]
debug patch

Can you apply this (download it, and then apply it with patch -p1 < path-to-patch.file) and paste the terminal output here?  Run with 'make run' to get the debug output, and to avoid having to install the binaries
Comment 9 Tim Elkins 2010-03-12 14:36:54 UTC
There's a missing 'else if' in the debug patch (I'm assuming it should be "} else if (mode_combo.Default != null) {"). Adding that, it compiles, starts up and crashes as before.
Comment 10 Tim Elkins 2010-03-12 14:37:39 UTC
Created attachment 155968 [details]
'make run' output
Comment 11 Gabriel Burt 2010-03-12 19:51:46 UTC
Created attachment 156010 [details] [review]
Cool, thanks Tim (and thanks for fixing up my patch).  Here's another one w/ some more output.  Also, it should print a warning to the terminal instead of crashing.  Can you apply/make run it?
Comment 12 Tim Elkins 2010-03-12 20:53:04 UTC
Created attachment 156015 [details]
'make run' output

With the 2nd patch applied after a git reset - still crashing.
Comment 13 Alexander Kojevnikov 2010-03-13 22:02:33 UTC
*** Bug 612817 has been marked as a duplicate of this bug. ***
Comment 14 Martin Beenham 2010-03-14 09:57:46 UTC
Just to log that 1.5.5 crashes on startup for me too.
Built from repo on Xubunti Jaunty.
Reverting to 1.5.1 works fine.
Comment 15 Valentín Conesa 2010-03-14 17:13:09 UTC
In 1.5.5 crashes for me too. I'm using Ubuntu Jaunty with repo. I've reverted to 1.5.1 and still crashes... ?????
Comment 16 Philip Gillißen 2010-03-14 17:20:49 UTC
I use Banshee daily PPA (last update 1 hour ago) and it crashes with the following log output.

Ubuntu 9.10 64 Bit

 $ banshee --version
 Banshee 1.6 RC1 (1.5.5) http://banshee-project.org
 Copyright 2005-2010 Novell, Inc. and Contributors.

I hope this bug will be fixed soon!
Comment 17 Philip Gillißen 2010-03-14 17:21:15 UTC
Created attachment 156128 [details]
Banshee crash log output
Comment 18 Alexander Kojevnikov 2010-03-15 02:18:26 UTC
(In reply to comment #16)
> I use Banshee daily PPA (last update 1 hour ago) and it crashes with the
> following log output.

It's another issue, the version of Mirage you have installed is incompatible with the latest version of Banshee. You need to upgrade Mirage, see bug 612407.
Comment 19 Philip Gillißen 2010-03-15 07:07:44 UTC
(In reply to comment #18)
> It's another issue, the version of Mirage you have installed is incompatible
> with the latest version of Banshee. You need to upgrade Mirage, see bug 612407.

Thanks a lot! Sorry for misusing this bug!
Comment 20 Michael Gorelick 2010-03-15 17:45:07 UTC
Same problem here.

uname -a : Linux sol 2.6.28-18-generic #59-Ubuntu SMP Thu Jan 28 01:40:19 UTC 2010 x86_64 GNU/Linux

/etc/issue: Ubuntu 9.04

Banshee 1.5.5: [Ubuntu 9.04 (linux-gnu, x86_64) @ 2010-03-12 01:03:37 UTC] (from PPA)

I have also purged all extensions just in case there was an incompatibility.
Comment 21 internaut_mako 2010-03-16 22:06:35 UTC
I can confirm this bug on Ubuntu 9.04 (Linux bemme 2.6.28-18-generic #59-Ubuntu SMP Thu Jan 28 01:23:03 UTC 2010 i686 GNU/Linux)... quite annoying - can't use banshee for days now :(
Comment 22 Gabriel Burt 2010-03-16 22:31:03 UTC
Ok, we are planning a RC 2 that should have a fix for this.  (Of course we still need to find a fix...)
Comment 23 Gabriel Burt 2010-03-16 22:53:35 UTC
Created attachment 156311 [details] [review]
patch

Ok, from looking at the trace with rested eyes, it's apparent it's an issue with the Changed callback.  It's probably a bug that's been fixed in Mono with using anonymous delegates.  I'm attaching a patch that gets rid of the anonymous delegate, which hopefully will solve it.  Please test!
Comment 24 Michael Gorelick 2010-03-16 23:20:46 UTC
Created attachment 156313 [details]
Debug after applying patch

I've attached the debug output after applying the patch to the current code on git.  Just in case, I applied it with "git apply --stat patch.diff".
Comment 25 Gabriel Burt 2010-03-16 23:24:52 UTC
Michael, I don't think you were running the version w/ the patch applied.  You can be sure to run it with "make && make run" which will run the uninstalled binaries (in bin/).
Comment 26 Michael Gorelick 2010-03-16 23:29:16 UTC
Gabriel; That is what I have done.  The exact sequence of what I did was:

git clone git://git.gnome.org/banshee
sudo apt-get build-dep banshee
cd banshee
wget -O patch.diff "https://bugzilla.gnome.org/attachment.cgi?id=156311"
git apply --stat patch.diff
./autogen.sh && make -j 16
make run &> debug

The output for the application of the patch was:

 .../Banshee.Widgets/DictionaryComboBox.cs          |    9 +++++
 .../Banshee.PlayQueue/HeaderWidget.cs              |   33 +++++++++++++-------
 2 files changed, 29 insertions(+), 13 deletions(-)
Comment 27 Gabriel Burt 2010-03-16 23:33:05 UTC
Michael, I still think you're not running with that patch applied somehow.  Are you running 'make && make run' from the top level Banshee directory (the one containing the src/ and bin/ folders)?

There is a line in the patch, Console.WriteLine ("PlayQueue.HeaderWidget.ctor have random by {0}", random_by.Id); that we are not seeing the output of in your log attachment.
Comment 28 Michael Gorelick 2010-03-16 23:43:12 UTC
Gabriel,

You were right!  the --stat in "git apply --stat patch.diff" only shows the changes that would be done but doesn't actually apply them.

Upon "make && make run"'ing the patch, everything runs smoothly!  Thanks so much for the fix.
Comment 29 Michael Gorelick 2010-03-16 23:43:37 UTC
Comment on attachment 156313 [details]
Debug after applying patch

The patch was not set correctly.
Comment 30 Gabriel Burt 2010-03-16 23:59:35 UTC
Excellent, thanks for testing, Michael!  Like I said, this fix with be in 1.5.6 (1.6 RC 2).  Sorry for the inconvenience everybody, thanks for helping us catch and fix this!

commit ee5f2b64e0541d70414df2be295e359078a74eb9
Author: Gabriel Burt <gabriel.burt@gmail.com>
Date:   Tue Mar 16 16:57:33 2010

    [PlayQueue] Workaround bad startup crash on old Mono
    
    Handling a ComboBox.Changed event with an anonymous delegate was causing
    a crash for users on older versions of Mono (bgo#612631)
Comment 31 Alexander Kojevnikov 2010-03-19 01:39:37 UTC
*** Bug 613290 has been marked as a duplicate of this bug. ***
Comment 32 Gabriel Burt 2010-03-20 18:27:08 UTC
*** Bug 613425 has been marked as a duplicate of this bug. ***
Comment 33 Thomas Sibley 2010-03-20 19:01:40 UTC
When does 1.5.6 come out?
Comment 34 Gabriel Burt 2010-03-20 19:07:12 UTC
I'm going to try to do it today.