After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610310 - [playbin2] Subtitle encoding property has no effect
[playbin2] Subtitle encoding property has no effect
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.26
Other Linux
: Normal blocker
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-17 21:31 UTC by Julian Sikorski
Modified: 2010-02-22 19:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
example subs (51.56 KB, text/plain)
2010-02-18 18:34 UTC, Julian Sikorski
  Details
playbin2, playsink, subtitleoverlay: Set subtitle encoding properly (14.95 KB, patch)
2010-02-21 18:54 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Julian Sikorski 2010-02-17 21:31:11 UTC
After upgrading to gstreamer-plugins-base-0.10.26-1.fc12 (from gstreamer-plugins-base-0.10.25.1-2.fc12), the totem subtitle encoding setting no longer seems to be respected. Even though I have set cp1250 there, the non-ascii characters in the subs are displayed as garbage. Downgrading to 0.10.25.1 fixes the problem.
Comment 1 Julian Sikorski 2010-02-18 18:34:43 UTC
Created attachment 154159 [details]
example subs
Comment 2 Sebastian Dröge (slomo) 2010-02-21 18:54:19 UTC
Created attachment 154334 [details] [review]
playbin2, playsink, subtitleoverlay: Set subtitle encoding properly

For this add subtitle encoding properties to playsink and subtitleoverlay
and update the values in the containing elements.

Also update the font description in textoverlay or the used renderer
element if it is changed during playback.

Fixes bug #610310.
Comment 3 Julian Sikorski 2010-02-21 20:09:52 UTC
I can confirm that the above patch fixes the problem.
Comment 4 Tim-Philipp Müller 2010-02-21 20:23:20 UTC
Great, thanks for testing. However, the bug should only be marked as FIXED once the fix has been committed, so reopening.
Comment 5 Sebastian Dröge (slomo) 2010-02-22 19:47:55 UTC
commit ff21fe1d25fea5e94d08e2ff5489e67a7356d3f5
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sun Feb 21 19:52:45 2010 +0100

    playbin2, playsink, subtitleoverlay: Set subtitle encoding properly
    
    For this add subtitle encoding properties to playsink and subtitleoverlay
    and update the values in the containing elements.
    
    Also update the font description in textoverlay or the used renderer
    element if it is changed during playback.
    
    Fixes bug #610310.