After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609472 - Stylesheets are untranslated in Edit->Style Sheets->Select HTML Style Sheets Dialog
Stylesheets are untranslated in Edit->Style Sheets->Select HTML Style Sheets ...
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Reports
git-master
Other All
: Normal minor
: ---
Assigned To: Andreas Köhler
Andreas Köhler
Depends on:
Blocks:
 
 
Reported: 2010-02-09 23:21 UTC by Frank H. Ellenberger
Modified: 2018-06-29 22:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Does that fix this problem? (655 bytes, patch)
2010-02-10 19:39 UTC, Christian Stimming
needs-work Details | Review

Description Frank H. Ellenberger 2010-02-09 23:21:25 UTC
The Names of the Stylesheets are untranslated in the Edit->Style Sheets->"Select HTML Style Sheets" Dialog. But they are translated in the report options->General->Stylesheet List Box. 

This makes it difficult for new users, to adjust the right stylesheet. With LANG=de_DE edit ... "Technicolor" relates to report ... "Bunt"

First I thought, we had a translation issue, but e.g. "Technicolor" exists only once (in the fancy stylesheet).

As src/report/stylesheets/stylesheet-fancy.scm:391 reads (gnc:make-html-style-sheet "Fancy" (N_ "Technicolor"))
, I /believe/, somewhere in src/report/report-system/report.scm a (_ ...) is missing.
Comment 1 Geert Janssens 2010-02-10 16:39:07 UTC
I wonder, should the stylesheet titles really be translated ? IMHO it's a bit odd.

Especially since users can add their own stylesheets and those names aren't translated.

In any case there is clearly an inconsistency that should be fixed by either translating the titles everywhere or nowhere.
Comment 2 Christian Stimming 2010-02-10 19:39:11 UTC
Created attachment 153462 [details] [review]
Does that fix this problem?
Comment 3 Frank H. Ellenberger 2010-02-10 23:17:30 UTC
(In reply to comment #1)
> I wonder, should the stylesheet titles really be translated ? IMHO it's a bit
> odd.

To make the confusion complete, the file stylesheet-fancy.scm defines the html-style-sheet "Fancy", which then gets the name "Technicolor", which then is translated in german to "Bunt".

OTOH that allows us, to translate the "default" one to "Standaard" or "Voreinstellung".

> Especially since users can add their own stylesheets and those names aren't
> translated.

As long as they derive their stylesheets from one of the existant and adjust the name, it is no problem. After they include it in the related makefile, it  will eventually appear in your .po file.    

Re #2:
Sorry, but this seems not to be the right place. Edit ... is still untranslated.
Comment 4 Christian Stimming 2010-12-03 21:15:10 UTC
r19903, done.
Comment 5 John Ralls 2018-06-29 22:34:48 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=609472. Please update any external references or bookmarks.