Here is a test case:

GST_DEBUG=*tsdemux*:5 gst-launch videotestsrc num-buffers=90 ! schroenc ! mpegtsmux  ! identity single-segment=1 ! mpegtsdemux ! fakesink 2>&1 | grep "PAT section" | wc -l

Created attachment 152925 [details] [review]
mpegtsmux: fix PAT/PMT insertion frequency

The current code is comparing timestamps with different clock.
Let's use only the clock for PTS values.

Also rename frequency to interval, to avoid confusion. And remove
documentation about value 0, which won't work like documented.

Created attachment 152926 [details] [review]
mpegtsmux: add pat-interval and pmt-interval properties

Created attachment 152927 [details] [review]
mpegtsmux: add PAT/PMT in streamheader

I think some of the patch depends on bug 604908 patch. Adding dep

Note: the first patch reduced PAT/PMT overhead by more than 10% for a low bitrate stream (at ~300kb). Said differently, the current mpegtsmux inserts ~100-300x too many PAT/PMT.

Review of attachment 152925 [details] [review]:

looks good

Review of attachment 152926 [details] [review]:

looks good

Review of attachment 152927 [details] [review]:

is_section is misleading. There are many sections in ts, not just the ones you are adding to streamheader (pat and pmt)

Created attachment 152943 [details] [review]
mpegtsmux: add PAT/PMT in streamheader

The check for PAT/PMT buffers was suggested by
Zaheer Abbas Merali.

Created attachment 152947 [details] [review]
mpegtsmux: add PAT/PMT in streamheader

The check for PAT/PMT buffers was suggested by
Zaheer Abbas Merali.

Created attachment 152950 [details] [review]
mpegtsmux: add PAT/PMT in streamheader

The check for PAT/PMT buffers was suggested by
Zaheer Abbas Merali.

Review of attachment 152950 [details] [review]:

looks good

the 3 patches have been committed by Zaheer.

closing