GNOME Bugzilla – Bug 604908
[mpegtsmux] mark delta-unit on outgoing buffers
Last modified: 2010-02-04 09:14:19 UTC
Created attachment 149990 [details] [review] mark delta-unit on outgoing buffers see patch
Makes sense, the use-case is to figure out where keyframes are located in the output stream, in order to do some splitting downstream at keyframe locations.
commit 5fab65aafbde8d05a202995c7756065a7eddd3a6 Author: Thomas Vander Stichele <thomas@apestaart.org> Date: Fri Dec 18 14:14:17 2009 +0100 mpegtsmux: mark delta-unit on outgoing buffers Signed-off-by: Marc-André Lureau <mlureau@flumotion.com>
reopening, since I found an issue with the patch from this bug
Created attachment 152431 [details] [review] mpegtsmux: marking non-delta unit, including pre-sections This patch address the issue observed with KF timestamps and delta flag. When a section is appended before the keyframe, it is not marked as non-delta. It's preferable to mark the first buffer non-delta. This patch also simplify the initial patch written by thomas, since it does not clutter tsmux/ with a delta flag passed around only for GStreamer convenience.
Created attachment 152924 [details] [review] mpegtsmux: marking non-delta unit, including pre-sections This patch address the issue observed with KF timestamps and delta flag. When a section is appended before the keyframe, it is not marked as non-delta. It's preferable to mark the first buffer non-delta. This patch also simplify the initial patch written by thomas, since it does not clutter tsmux/ with a delta flag passed around only for GStreamer convenience.
Review of attachment 149990 [details] [review]: this patch has been committed a while back
Review of attachment 152924 [details] [review]: Looks good
patch committed by Zaheer This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.