After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607522 - [ENH] add ADDRESS to check printing
[ENH] add ADDRESS to check printing
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Check Printing
git-master
Other All
: Normal enhancement
: ---
Assigned To: David Hampton
Depends on: 607517
Blocks:
 
 
Reported: 2010-01-20 06:17 UTC by Thomas Troesch
Modified: 2018-06-29 22:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[ENH] add ADDRESS to check printing (116.83 KB, patch)
2010-01-20 06:17 UTC, Thomas Troesch
committed Details | Review

Description Thomas Troesch 2010-01-20 06:17:04 UTC
Created attachment 151815 [details] [review]
[ENH] add ADDRESS to check printing

[ENH] add ADDRESS to check printing

The patch does three things.

1.  Adds the ability to print an address on checks.  The Print Check dialog is changed to have 5 address lines.
The first field is filled in with the same data as the PAYEE check item.  The other lines are blank.  The check format keys
have a new check-item type 'ADDRESS'.  It behaves like other text check-item types.  The address fields on the dialog are set 'not-sensitive'
if the current format does not have an ADDRESS check item defined.  The Custom Field tab has a new line for the address
location.

2.  Added new check format key - Blocking_Chars.  This is to put the blocking character feature into the check format file.  It is currently
only in the preferences dialog in the printing tab, and therefore currently applies (or not) to all text fields in th_e check format.  By
adding the key Blocking_Chars_n to the check format, the blocking characters can be applied to text type check-items individually.  Its
really useful when printing stubs and so on.  (NOTE:  blocking characters are printed around a field to protect against alteration
e.g.  ***$100.00***  vs     $100.00)

3. Included a Voucher check template.  This is a full page check with the check on top and which has two stubs below.  There
are other voucher formats ( middle and bottom ) , but the check printing functionality would require separate templates for
the different formats.  Also changed the Quicken/Quickbooks US-Letter check format to include the ADDRESS check item and blocking
around the AMOUNT_NUMBER field.  I made a change to the Quicken-wallet check to add blocking characters around the
AMOUNT_NUMBER field, and I added a clipping rectangle definition to the NOTES and PAYEE fields the were placed in the 
check stub area ( if the fields were too long, they would print into the check area ).
Comment 1 Thomas Troesch 2010-01-20 06:18:26 UTC
requires 607517
Comment 2 Christian Stimming 2010-01-21 13:19:46 UTC
Comment on attachment 151815 [details] [review]
[ENH] add ADDRESS to check printing

Is the patch correct even after bug#607517 has been applied? But OTOH this isn't much of a problem - the other bug can be committed first and through git rebase this patch can be added afterwards.
Comment 3 Thomas Troesch 2010-01-21 22:16:10 UTC
I'm not sure that I built the patches correctly, since I've never used svn before.  I thought I was making 607522 based on 607517.  So proceed with care.
Comment 4 Christian Stimming 2010-01-23 21:49:05 UTC
Comment on attachment 151815 [details] [review]
[ENH] add ADDRESS to check printing

r18581, thanks!
Comment 5 Christian Stimming 2010-01-23 21:51:54 UTC
FTR: This patch had not taken bug#607517 into account, but I was prepared for this and using git-svn I could easily rebase this patch on SVN-trunk which now hat bug#607517 already included.

Did you change the wording of "Blocking" into "Blocking Char" or similar, as discussed in private email? But further changes to this feature can of course be added as subsequent patches into SVN.
Comment 6 Thomas Troesch 2010-01-24 21:02:39 UTC
Yes.  However, the diff that I attached was not the one that was used.  An earlier one ( where the key is 'Blocking' ) was used.  It appears that the current code is consistent, but doesn't fit the bug description.  I'm glad that I'm not the only source of my confusion:)

So I will open a new bug and make a diff based on the current svn trunk.
Comment 7 Christian Stimming 2010-01-24 21:06:58 UTC
I used an earlier one? Oops - obviously I didn't check closely enough which of the "recently saved" files I should use as a patch. Sorry for that. A new diff would be nice, indeed. Thanks a lot!
Comment 8 Thomas Troesch 2010-02-09 07:23:16 UTC
I just realized that I never made a diff to make the key 'Blocking_Chars'.  The reason is that I included that change in a patch I submitted to bug 534210.
Comment 9 John Ralls 2018-06-29 22:33:48 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=607522. Please update any external references or bookmarks.