After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606951 - No mention of howto disable keyboard shortcuts in help
No mention of howto disable keyboard shortcuts in help
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: docs
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
GNOME Terminal Maintainers
: 606654 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-14 12:27 UTC by Pedro Villavicencio
Modified: 2013-03-03 23:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
Keybinding-editor patch to show how to disable a shortcut (731 bytes, patch)
2010-01-14 13:03 UTC, Skippy le Grand Gourou
none Details | Review
Keybinding-editor patch to show how to disable a shortcut (731 bytes, patch)
2010-01-14 13:08 UTC, Skippy le Grand Gourou
rejected Details | Review

Description Pedro Villavicencio 2010-01-14 12:27:36 UTC
this report has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/gnome-terminal/+bug/505727

"When going into Keyboard Shortcuts in gnome-terminal, there is no clear indication on how a user can disable a keyboard shortcut. The interface does not currently suggest a way for the user to know that double click the shortcut key area and then hitting backspace will disable that shortcut. The help file has no mention of this functionality as well."

the reporter also provided a patch:

http://launchpadlibrarian.net/37834877/gnome-terminal.xml.diff

"I've attached a proposed patch to gnome-terminal.xml to update the help on how to go about disabling a keyboard shortcut. This would just need translations for the other available languages."

Thanks in advance,
Comment 1 Christian Persch 2010-01-14 12:45:17 UTC
*** Bug 606654 has been marked as a duplicate of this bug. ***
Comment 2 Skippy le Grand Gourou 2010-01-14 13:03:17 UTC
Created attachment 151393 [details] [review]
Keybinding-editor patch to show how to disable a shortcut

Note that the above patch is only half the solution IMO : as the way to change a shortcut is straightforward, so should be the way to disable it.  As it is not the case, a statement indicating how to do that should be added *inside* the gnome-terminal keyboard shortcuts windows.  The attached patch shows a simple implementation of what I mean (for gnome-terminal 2.24.3 1.fc10 (Fedora 10)).
Comment 3 Skippy le Grand Gourou 2010-01-14 13:08:17 UTC
Created attachment 151394 [details] [review]
Keybinding-editor patch to show how to disable a shortcut

Sorry, should have checked carefully the patch, was done the wrong way.
Comment 4 Christian Persch 2010-01-14 13:18:10 UTC
+		<para>To disable a keyboard shortcut, double-click the <guilabel>Shortcut Key</guilabel> for the desired <guilabel>Action</guilabel> and click Backspace.</para>

"click" Backspace? "press the Backspace key" would be more like it.
Comment 5 Christian Persch 2010-01-14 13:18:29 UTC
Comment on attachment 151394 [details] [review]
Keybinding-editor patch to show how to disable a shortcut

This patch is wrong. Firstly, the .ui file is generated, the .glade file is the source. Secondly, we don't generally put such help text in the UI itself. If anything, there should be some button, or buttons in the treeview, to re-set the keybinding to default/to disable it.
Comment 6 Skippy le Grand Gourou 2010-01-14 13:31:30 UTC
(In reply to comment #5)
> This patch is wrong. Firstly, the .ui file is generated, the .glade file is the
> source. 

Well, thanks for the clarification.  However I couldn't find any keybinding-editor.glade file on my system (must be in some source package ?) and anyway the patch was there as an illustration only, not as a definitive proposal.


> Secondly, we don't generally put such help text in the UI itself. If
> anything, there should be some button, or buttons in the treeview, to re-set
> the keybinding to default/to disable it.

Oh, I thought simplicity was one of the main keywords of the gnome project, must be a misunderstanding there…  Kidding apart, this is not the policy implemented in gnome-keybinding-properties (which I found while looking for a .glade file), which actually explains in the UI itself how to disable a keybinding :

<widget class="GtkLabel" id="label12">
                      <property name="visible">True</property>
                      <property name="label" translatable="yes">To edit a shortc
ut key, click on the corresponding row and type a new key combination, or press 
backspace to clear.</property>
Comment 7 Andrei 2012-08-05 17:03:07 UTC
The text "To edit a shortcut, click the row and hold down the new keys or press Backspace to clear." is added as a label to gnome-control-center>Keyboard>Shortcuts.
Could the text be added to Terminal also? Could it be mentioned otherwise in Help?
I've first tried these before finding the answer on google:
- select the row and press DELETE
- select the row and press Backspace (I've vaguely remembered something about delete)
- select the row, try to assign a key and then pressed DELETE

The text should be somehow clearer: "To disable a shortcut, set the accelerator as the key Backspace", because just clicking the row + pressing Backspace won't help. Of course it could be longer if it's a text entry in Help file and not a label.
Comment 8 Kat 2013-03-03 23:09:34 UTC
This is now explained on the shortcuts page in the new help.