After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602244 - Google contact
Google contact
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.28.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
evolution[google]
: 571851 604939 611592 613259 621826 625330 629744 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-17 20:36 UTC by TruongSinh Tran
Modified: 2011-08-17 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Enable key fields (13.01 KB, patch)
2010-02-25 01:02 UTC, Jim McMahon
none Details | Review
Add ORG support to the Google Contacts backend (9.79 KB, patch)
2010-04-21 15:37 UTC, Philip Withnall
committed Details | Review
Add NOTE support to the Google Contacts backend (3.37 KB, patch)
2010-04-21 15:37 UTC, Philip Withnall
committed Details | Review

Description TruongSinh Tran 2009-11-17 20:36:20 UTC
Google Contacts APIs http://code.google.com/apis/contacts/ now supports syncing images, Family Name, Given Name, Additional Name, notes, etc.

Can we enable more field to be edited in Evolution? As using 2.28 on Ubuntu Karmic, I find it pity I can only edit the whole display name. It sometimes even break the name structure. Also, it is impossible to add image or notes.

PS: it is technically feasible, because the syncing between iPhone and Google Contact via wireless is so far so good.
Comment 1 Akhil Laddha 2009-12-08 10:11:45 UTC
*** Bug 571851 has been marked as a duplicate of this bug. ***
Comment 2 Akhil Laddha 2009-12-08 10:13:56 UTC
two more fields Company and Title from bug 571851
Comment 3 Akhil Laddha 2009-12-21 04:53:05 UTC
*** Bug 604939 has been marked as a duplicate of this bug. ***
Comment 4 Jim McMahon 2010-02-25 01:02:49 UTC
Created attachment 154650 [details] [review]
Enable key fields

This patch enables 3 key fields which I find quite necessary and make heavy use of in my google contacts:

    Company (aka Organization)
    Job Title
    Notes

Without this patch, these fields are disabled/gray.  I've been using this mod with 2.28.1 on karmic.  Even though the code changes touch only the evolution-data-server package, you will also need to build the evolution front-end as, I believe, it uses some of the header files that I've modified on the server in this patch.  Also, run:

  evolution --force-shutdown' and
  mv ~/.evolution/cache/addressbook/jim@madbongo.net/cache.xml /tmp

Then start your newly patched evolution.  If you're going to build with this patch then you'll probably also want my other patch found under bug 570508.
Comment 5 Jim McMahon 2010-02-25 01:06:06 UTC
Correction:

  evolution --force-shutdown
  mv ~/.evolution/cache/addressbook/<YOUR_EMAIL_ADDRESS>/cache.xml /tmp
Comment 6 Akhil Laddha 2010-03-03 03:56:42 UTC
*** Bug 611592 has been marked as a duplicate of this bug. ***
Comment 7 Akhil Laddha 2010-03-19 03:29:19 UTC
*** Bug 613259 has been marked as a duplicate of this bug. ***
Comment 8 Matthew Barnes 2010-04-08 02:25:15 UTC
Philip, would you mind taking a look at this patch and see if your recent libgdata patches already cover this?
Comment 9 Philip Withnall 2010-04-09 21:51:05 UTC
(In reply to comment #8)
> Philip, would you mind taking a look at this patch and see if your recent
> libgdata patches already cover this?

None of it's covered by the patch in bug #580021, but support for it could be added after my patch is applied quite easily, and without needing to bump the libgdata version.
Comment 10 Philip Withnall 2010-04-21 15:37:32 UTC
Created attachment 159263 [details] [review]
Add ORG support to the Google Contacts backend
Comment 11 Philip Withnall 2010-04-21 15:37:52 UTC
Created attachment 159265 [details] [review]
Add NOTE support to the Google Contacts backend
Comment 12 Philip Withnall 2010-04-21 15:41:36 UTC
The two patches above supersede the patch from comment #4, and add as full as possible support for ORG and NOTE attributes.

As far as I can tell, the only things remaining where libgdata 0.6.x has the API to allow us to support them are images and groups. Blocking on the network requests could be a problem for image support, and I'm not entirely sure if the current groups API in libgdata will be enough to fully support contact groups using libgdata 0.6.x. I'm looking into it.
Comment 13 Chenthill P 2010-05-19 12:20:11 UTC
Review of attachment 159263 [details] [review]:

Please commit the patch to master and stable (gnome-2-30) branches.
Comment 14 Chenthill P 2010-05-19 12:20:52 UTC
Review of attachment 159265 [details] [review]:

Please commit the patch to master and stable (gnome-2-30) branches.
Comment 15 Philip Withnall 2010-05-19 21:37:57 UTC
Committed to master. It's non-trivial to commit these patches to gnome-2-30, since they are fairly tied in with my changes from bug #580021.

I haven't had time to look into image or groups support like I said I would, and I'm about to head into a week or two of exams. I'll look into them after the 9th; poke me if I don't.

commit 8b3b96837f4590f75547640b7a9a9306a23cd4fa
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Apr 21 16:34:54 2010 +0100

    Add NOTE support to the Google Contacts backend
    
    Closes: bgo#602244

 .../backends/google/e-book-backend-google.c        |    3 +-
 addressbook/backends/google/util.c                 |   21 ++++++++++++++++---
 2 files changed, 19 insertions(+), 5 deletions(-)

commit 597db68b57d897ef43f590e4344d995af464d917
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Apr 21 16:13:49 2010 +0100

    Add ORG support to the Google Contacts backend
    
    This includes ORG_NAME, TITLE and ROLE support. Helps: bgo#602244

 .../backends/google/e-book-backend-google.c        |    6 +-
 addressbook/backends/google/util.c                 |  136 +++++++++++++++++++-
 2 files changed, 138 insertions(+), 4 deletions(-)
Comment 16 Philip Withnall 2010-05-19 21:57:03 UTC
I've filed bug #619135 about the photo stuff, and bug #566441 is about adding group support, so I'll consider this one fixed.
Comment 17 Milan Crha 2010-09-22 16:59:53 UTC
*** Bug 629744 has been marked as a duplicate of this bug. ***
Comment 18 Milan Crha 2011-04-05 09:22:16 UTC
*** Bug 625330 has been marked as a duplicate of this bug. ***
Comment 19 Milan Crha 2011-08-17 07:12:32 UTC
*** Bug 621826 has been marked as a duplicate of this bug. ***