After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602124 - Y-axis labels of Network Usage graph trimmed, unreadable
Y-axis labels of Network Usage graph trimmed, unreadable
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Robert Roth
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-16 18:16 UTC by Alexey Kotlyarov
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
attached a proposed patch at launchpad bug report (366 bytes, patch)
2010-05-02 07:49 UTC, Omer Akram
none Details | Review
git formatted patch (809 bytes, patch)
2011-11-09 09:15 UTC, Robert Roth
none Details | Review

Description Alexey Kotlyarov 2009-11-16 18:16:10 UTC
In ru_RU locale, gnome-system-monitor's Network Usage graph Y axis labels are trimmed, making them unreadable. (The strings used are, e.g. "Кбайт/с" versus "KiB/s".)

The bug is originally reported here: https://bugs.launchpad.net/ubuntu/+source/gnome-system-monitor/+bug/460021
A screenshot can be found here: http://launchpadlibrarian.net/34334613/gnome-system-monitor_RU.png
Comment 1 Omer Akram 2010-05-02 07:49:50 UTC
Created attachment 160124 [details] [review]
attached a proposed patch at launchpad bug report
Comment 2 Robert Roth 2011-11-09 09:15:52 UTC
Created attachment 201047 [details] [review]
git formatted patch

I have updated the patch to apply for the latest trunk, and tested it, and as it is working and fixes the issue reported here, should be applied.
Comment 3 Chris Kühl 2011-11-09 22:58:21 UTC
I don't like the fact that these are using fixed values. I think one can use pango to get the width of the text using a particular font. It'd be best to use that information so that we aren't wasting space unnecessarily.

All the graphs should line up so we'd need to find the max width needed.
Comment 4 Robert Roth 2011-11-10 09:53:53 UTC
Yes, agreed on that. I have only found that the starting x position of the graphs is indent+rmargin, and rmargin is the on that depends on the current fontsize (with a multiplier), so the multiplier should be increased, not the indent. I'll create another patch for that.
Comment 5 Robert Roth 2011-11-10 10:46:42 UTC
The fix for bug 536006 from commit 62c46d71e8c4ab5a2e68f7b1ad9d780c1728b6e2 has also fixed this issue, after pulling from git the issue is not reproducible anymore with the languages which had this issue (he_IL and ru_RU), so I am closing this as fixed.  The fix will be available in the next major software release.