GNOME Bugzilla – Bug 536006
Don't use cairo_show_text()
Last modified: 2011-11-11 10:03:55 UTC
Reading this: http://sankarshan.randomink.org/blog/2008/05/30/oh-no-system-monitor-seems-to-be-acting-up/ I suspect it's using cairo_show_text to render some of the labels. Should use pango_cairo_show_layout insted.
*** Bug 521930 has been marked as a duplicate of this bug. ***
Bug still exist with Fedora package: gnome-system-monitor-2.26.1-2.fc11.x86_64
*** Bug 574527 has been marked as a duplicate of this bug. ***
Currently out of 3 column, 2 are Fixed with following version. gnome-system-monitor-2.28.0-2.fc12.x86_64
Created attachment 177070 [details] Just take a look at the units in the graph
Created attachment 194321 [details] [review] Use pango instead of cairo_show_text in load-graph. Hi, Here's a patch that uses Pango instead. I tried it for Hebrew and English, and it seemed to work fine.
Review of attachment 194321 [details] [review]: The patch looks generally ok, and fixes the issue reported, but there are two possible problems with it: I think that the Pango layout should be unreffed (g_object_unref at the end of the method before the last cairo_stroke) and the Pango font_description should be freed after it has been set to the layout (pango_font_description_free(font_desc) after pango_layout_set_font_description call). These two changes do not affect the behavior of the patch, the app is still compilable and runnable.
Created attachment 201050 [details] [review] Updated patch with free and unref Confirmed the bug and attached a patch superseding the previous one with the original commit author set and cleaning up the objects from memory when they are not needed anymore.
Thanks. This has been applied to master in commit 62c46d71e8c4ab5a2e68f7b1ad9d780c1728b6e2.