After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601578 - Add "Firefox style" info bar to save room password
Add "Firefox style" info bar to save room password
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on: 601577
Blocks:
 
 
Reported: 2009-11-11 17:24 UTC by Guillaume Desmottes
Modified: 2011-02-01 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
diff (22.86 KB, patch)
2011-01-31 09:38 UTC, Guillaume Desmottes 		reviewed Details | Review

Description Guillaume Desmottes 2009-11-11 17:24:07 UTC 
Once the info bar is still displayed while joining the room (bug #601577), we could add an option offering to the user to save the room password (in gnome-keyring).
Comment 1 Jonny Lamb 2011-01-27 09:40:08 UTC 
This is now even easier with the empathy_keyring functions I added. Admittedly, you'll have to do a bit of badgering to add non-account-password secrets.
Comment 3 Guillaume Desmottes 2011-01-31 09:38:56 UTC 
Created attachment 179702 [details] [review]
diff
Comment 4 Guillaume Desmottes 2011-01-31 09:47:08 UTC 
Review of attachment 179702 [details] [review]:

Wouh, awesome!

::: libempathy/empathy-keyring.c
@@ +299,3 @@
+    GError **error)
+{
+  GSimpleAsyncResult *simple;

How do you feel about stealing tp-glib's _finish macros and make use of them?
Comment 5 Jonny Lamb 2011-02-01 08:54:34 UTC 
Woo, all merged.