GNOME Bugzilla – Bug 601577
Add a throbber in the info bar when joining a room protected room
Last modified: 2011-01-28 13:22:56 UTC
<wjt> cassidy: does the bar disappear when you first press "join" and then reappear if there's an error? <cassidy> yes <wjt> cassidy: might be nicer to have a throbber in the bar, and have the bar only vanish once you're actually connected
Created attachment 179503 [details] [review] chat: display a spinner when attempting a MUC password Here's a patch. The branch is here: http://git.collabora.co.uk/?p=user/jonny/empathy.git;a=shortlog;h=refs/heads/muc-password Two things about this: 1. When you *click* the button to try the password it doesn't become insensitive. This is a GTK3 bug (bug #640809). 2. I can't right-align that bloody GtkSpinner. If you could have a little look that'd be awesome! Perhaps another GTK3 annoyance?
Review of attachment 179503 [details] [review]: Looks good, I think you have to play with the expand and fill arguments when packing your widget. Maybe look at how the retry/edit/close buttons are packed in the connection error info bar? Does your branch rebase well on top of 2.34? That's something that could be nice to backport.
Merrrrrrrrrrrrrrrrrrrrrrrrged!