After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601304 - Search stopped showing results when the previous query doesnt yield any results
Search stopped showing results when the previous query doesnt yield any results
Status: RESOLVED DUPLICATE of bug 600890
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-09 20:47 UTC by Nageswara Rao M
Modified: 2009-11-10 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix bug in search functionality (1.07 KB, patch)
2009-11-09 20:47 UTC, Nageswara Rao M 		needs-work Details | Review

Description Nageswara Rao M 2009-11-09 20:47:58 UTC 
Created attachment 147321 [details] [review]
patch to fix bug in search functionality

When we give a query which doesnt have any results, header and resultArea are
getting hidden. But they are not shown again next time, when we give a new
query.  

Repro steps:
give firefoxzzz as a query and you shouldn't see any results. Then, give
another normal query which has some results to show, say firefox. these results
will not be shown. I'm attaching a patch which solves the problem to this mail. 

Thanks.
Naagas.
Comment 1 Owen Taylor 2009-11-09 21:16:58 UTC 
Review of attachment 147321 [details] [review]:

::: js/ui/dash.js
@@ -823,4 +824,2 @@
                 if (itemCount == 0) {
                     section.resultArea.actor.hide();
-                } else {
-                    section.resultArea.actor.show();

If changing

 hide();

to:

 show();
 hide();

Makes any difference, then there's a bug somewhere else. Is this a dup of bug 600890?
Comment 2 Nageswara Rao M 2009-11-10 06:47:05 UTC 
Hello Taylor,
calling show will actually invoke onMapped callback in genericDisplay.js which will do redisplay based on pendingflags. Yes this bug is dupe of 601030 and can be fixed by 600890 or the patch that i've provided.
Comment 3 Colin Walters 2009-11-10 15:41:43 UTC 
Thanks for the patch!  However, I'm marking this as a duplicate since I think the 600890 patch is more correct.

*** This bug has been marked as a duplicate of bug 600890 ***