After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600890 - [genericDisplay] When setting a search, do a redisplay immediately
[genericDisplay] When setting a search, do a redisplay immediately
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 601030 601304 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-05 22:20 UTC by Colin Walters
Modified: 2009-11-10 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[genericDisplay] When setting a search, do a redisplay immediately (3.23 KB, patch)
2009-11-05 22:20 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2009-11-05 22:20:44 UTC
Commit 94bd6f17180f0a8cbdbf2a66a47469fce601a9e1 introduced a trick
where we only do the heavy lifting for "redisplay" when we're mapped.

However, the search system wants to get the count of matched items,
and control the visibility of the display based on that.  This introduces
a circularity; avoid it by forcing the search to do a redisplay.

In the future we should avoid this by separating out the "get matched
things for search" from "display list of things".
Comment 1 Colin Walters 2009-11-05 22:20:46 UTC
Created attachment 147045 [details] [review]
[genericDisplay] When setting a search, do a redisplay immediately
Comment 2 Colin Walters 2009-11-06 23:49:36 UTC
*** Bug 601030 has been marked as a duplicate of this bug. ***
Comment 3 Owen Taylor 2009-11-09 21:18:50 UTC
Review of attachment 147045 [details] [review]:

Looks good to me.
Comment 4 Colin Walters 2009-11-10 15:41:43 UTC
*** Bug 601304 has been marked as a duplicate of this bug. ***