After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599677 - Add brightness to the media-keys popup
Add brightness to the media-keys popup
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 594664
 
 
Reported: 2009-10-26 17:01 UTC by Bastien Nocera
Modified: 2009-11-06 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add brightness to the media-keys popup (7.68 KB, patch)
2009-10-26 17:01 UTC, Bastien Nocera 		reviewed Details | Review
Add brightness to the media-keys popup (7.66 KB, patch)
2009-10-28 13:22 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2009-10-26 17:01:40 UTC 
So that gnome-power-manager can copy/paste the files instead
of forking the code.
Comment 1 Bastien Nocera 2009-10-26 17:01:42 UTC 
Created attachment 146277 [details] [review]
Add brightness to the media-keys popup

So that gnome-power-manager can copy/paste the files instead
of forking our code.
Comment 2 Jens Granseuer 2009-10-26 20:44:52 UTC 
Review of attachment 146277 [details] [review]:

Patch looks good to me in general. Shouldn't gpm rather install the icon into the hicolor theme instead of us rummaging around in its files, though?
Comment 3 Bastien Nocera 2009-10-27 22:57:08 UTC 
(In reply to comment #2)
> Review of attachment 146277 [details] [review]:
> 
> Patch looks good to me in general. Shouldn't gpm rather install the icon into
> the hicolor theme instead of us rummaging around in its files, though?

gnome-settings-daemon wouldn't use the icons, the code is only there for the test app.
Comment 4 Bastien Nocera 2009-10-28 13:22:18 UTC 
Created attachment 146421 [details] [review]
Add brightness to the media-keys popup

So that gnome-power-manager can copy/paste the files instead
of forking our code.
Comment 5 Jens Granseuer 2009-10-28 17:11:45 UTC 
Review of attachment 146421 [details] [review]:

Ok. Looks to me like that part of the code needs your G_SEAL treatment, too, then.
Comment 6 Bastien Nocera 2009-10-28 17:18:02 UTC 
The G_SEAL patch is on top of this one, so it's already done.
Comment 7 Jens Granseuer 2009-10-28 17:28:36 UTC 
Good for you. ;-)
Comment 8 Bastien Nocera 2009-11-06 18:19:20 UTC 
Attachment 146421 [details] pushed as 7e4ce82 - Add brightness to the media-keys popup